Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cachi2): copy all files generated by cachi2 #2135

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(cachi2): copy all files generated by cachi2 #2135

merged 1 commit into from
Dec 3, 2024

Conversation

MartinBasti
Copy link
Contributor

Rubygems package manager contains data also out of deps/ and app/ directory. The whole remote dir must be copied.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

chmeliik
chmeliik approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubygems package manager contains data also out of deps/ and app/

Could you just add what kind of data?

@MartinBasti
Copy link
Contributor Author

Rubygems package manager contains data also out of deps/ and app/

Could you just add what kind of data?

@eskultety what exactly does it contain?

@MartinBasti
fix(cachi2): copy all files generated by cachi2
f619475 
Rubygems package manager contains data also out of deps/ and app/
directory. The whole remote dir must be copied.

For rubygems, bundler config file hasn't been copied.

Signed-off-by: Martin Basti <mbasti@redhat.com>
@MartinBasti
Copy link
Contributor Author

@chmeliik updated commit msg, it was missing bundled config file

@MartinBasti MartinBasti merged commit c8abb4e into containerbuildsystem:feature_cachi2 Dec 3, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmeliik chmeliik chmeliik approved these changes

@eskultety eskultety eskultety approved these changes

@ben-alkov ben-alkov Awaiting requested review from ben-alkov

@rcerven rcerven Awaiting requested review from rcerven

@mkosiarc mkosiarc Awaiting requested review from mkosiarc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinBasti @eskultety @chmeliik