Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update urllib version #1137

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

mkosiarc
Copy link
Contributor

@mkosiarc mkosiarc commented Aug 6, 2024

The reason are the dependabot security vulnerability alerts. Anything
above 1.26.19 should fix them.

The code also had to be updated, to replace method_whitelist with
allowed_methods. See https://github.com/urllib3/urllib3/blob/main/CHANGES.rst#1260-2020-11-10

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates

The reason are the dependabot security vulnerability alerts. Anything
above 1.26.19 should fix them.

The code also had to be updated, to replace method_whitelist with
allowed_methods. See https://github.com/urllib3/urllib3/blob/main/CHANGES.rst#1260-2020-11-10

Signed-off-by: mkosiarc <mkosiarc@redhat.com>
@mkosiarc
Copy link
Contributor Author

mkosiarc commented Aug 7, 2024

tested in osbs-pr-acceptance-test 279

@mkosiarc mkosiarc merged commit dfeac86 into containerbuildsystem:master Aug 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants