Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for -a and --attach in run #3157

Merged
merged 1 commit into from
Jul 17, 2024
Merged

feat: support for -a and --attach in run #3157

merged 1 commit into from
Jul 17, 2024

Conversation

CodeChanning
Copy link
Contributor

Adds support for the -a, --attach in nerdctl run

Address #3113

Context:

@CodeChanning CodeChanning force-pushed the attach_run branch 8 times, most recently from 0f25245 to 9479326 Compare July 10, 2024 21:11
@CodeChanning CodeChanning marked this pull request as ready for review July 10, 2024 21:32
pendo324
pendo324 reviewed Jul 10, 2024
View reviewed changes
pkg/taskutil/taskutil.go Outdated Show resolved Hide resolved
pkg/containerutil/containerutil.go Outdated Show resolved Hide resolved
Shubhranshu153
Shubhranshu153 reviewed Jul 11, 2024
View reviewed changes
pkg/containerutil/containerutil.go Outdated Show resolved Hide resolved
cmd/nerdctl/container_run.go Show resolved Hide resolved
@CodeChanning CodeChanning force-pushed the attach_run branch 5 times, most recently from a45c25e to e2f98dd Compare July 12, 2024 19:58
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Jul 16, 2024
@AkihiroSuda
Copy link
Member

Please rebase again, then CI will be green again

@CodeChanning
feat: support for -a and --attach in run
cf0e6e6 
Signed-off-by: CodeChanning <chxgaddy@amazon.com>
AkihiroSuda
AkihiroSuda approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 370cab6 into containerd:main Jul 17, 2024
19 checks passed
@github-actions github-actions bot mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondavidb sondavidb sondavidb left review comments

@Shubhranshu153 Shubhranshu153 Shubhranshu153 left review comments

@pendo324 pendo324 pendo324 left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@CodeChanning @AkihiroSuda @pendo324 @Shubhranshu153 @sondavidb