fix: save multiple images for the same image id to a tar archive #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jan 17, 2025
cmd/nerdctl/image/image_save_test.go
Outdated
| @@ -138,3 +138,60 @@ func TestSave(t *testing.T) { | |||
|
|
|||
| testCase.Run(t) | |||
| } | |||
|
|
|||
| // TestIssue3806 tests https://github.com/containerd/nerdctl/issues/3806 | |||
| func TestIssue3806(t *testing.T) { | |||
There was a problem hiding this comment.
Can we have a more descriptive test name?
There was a problem hiding this comment.
Thanks for commnets ! I've updated.
Suppose we try to save multiple container images with the same image ID but different image names into a tar archive using the nerdctl save command. When we then try to load container images from this tar archive using the nerdctl load command, not all container images will be loaded. This behavior is reported and the details are described in the following: - containerd#3806 Therefore, this PR resolves this issue. Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
haytok
force-pushed
the
nerdctl_issue_3806
branch
from
7656bdb to
9a6426d
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose we try to save multiple container images with the same image ID but different image names into a tar archive using the nerdctl save command.
When we then try to load container images from this tar archive using the nerdctl load command, not all container images will be loaded.
This behavior is reported and the details are described in the following:
Therefore, this PR resolves this issue.