Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OS Features in the format #16

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented Nov 1, 2024

Updates the os part of the format to include features after the os version. The guarantees that the format may fully represent the platform structure.

I propose we consider including the features in the format for 1.0 release, which we are trying to finalize.

Should we consider "/" or "+" as supported parts of OS features here? Right now the spec does not specify but we can define our own limitations. We could support it either by updating the parser (less backwards compatible) or URL encoding (ugly, but could be an edge case so who cares).

@tianon
Copy link
Member

tianon commented Nov 3, 2024

Does the format already support (non-OS) features?

(I don't think either are currently used for anything serious, but if we're going to support one we should probably support the other too.)

@dmcgowan
Copy link
Member Author

dmcgowan commented Nov 3, 2024

Does the format already support (non-OS) features?

Which format are you referring to?

In OCI there are non-OS features reserved, but not sure if that will ever be defined or added to the struct. I don't know where the line would be drawn in this case in regards to OS feature vs non-OS feature. It could be a hardware feature stuffed in as an OS feature, but what really is the difference if any hardware feature ends up being visible through the OS anyway. This is more for completeness of avoid compatibility later on when we want to add it, as had been previously discussed and recently inquired about.

Updates the os part of the format to include features after the os
version. The guarantees that the format may fully represent the platform
structure.

Signed-off-by: Derek McGowan <derek@mcg.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants