downgrade minimum required version of hcsshim to v0.10.0 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the minimum required version for hcsshim's "osversion" package to v0.10.0, which is the first (non-rc) version providine the `CheckHostAndContainerCompat` utility that's used, which was added in [microsoft/hcsshim@640a560]. Containerd 1.6 LTS currently uses hcsshim [v0.9.10], so would need to be updated to use the platforms module. Containerd 1.7 already uses hcsshim [v0.11.4], so can continue using that version (or higher if needed). This patch downgrades the required version to the lowest version providing the `CheckHostAndContainerCompat`, to make Go modules "minimum version selection" work, and to allow consumers to select a version of the hcsshim needed for their use (any version higher than v0.10.0). [microsoft/hcsshim@640a560]: microsoft/hcsshim@640a560 [v0.9.10]: https://github.com/containerd/containerd/blob/v1.6.27/go.mod#L9 [v0.11.4]: https://github.com/containerd/containerd/blob/v1.7.12/go.mod#L10 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
dmcgowan
approved these changes
Jan 20, 2024
12 tasks
dcantah
approved these changes
Jan 20, 2024
|
Shall we release v0.1.1? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the minimum required version for hcsshim's "osversion" package to v0.10.0, which is the first (non-rc) version providine the
CheckHostAndContainerCompatutility that's used, which was added in microsoft/hcsshim@640a560.Containerd 1.6 LTS currently uses hcsshim v0.9.10, so would need to be updated to use the platforms module. Containerd 1.7 already uses hcsshim v0.11.4, so can continue using that version (or higher if needed).
This patch downgrades the required version to the lowest version providing the
CheckHostAndContainerCompat, to make Go modules "minimum version selection" work, and to allow consumers to select a version of the hcsshim needed for their use (any version higher than v0.10.0).