Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: STATUS wording #1003

Merged
merged 1 commit into from
Dec 4, 2023
Merged

spec: STATUS wording #1003

merged 1 commit into from
Dec 4, 2023

Conversation

squeed
Copy link
Member

@squeed squeed commented Jun 19, 2023

This adds a new verb, STATUS, which indicates whether or not a plugin is ready to accept ADD requests. Runtimes may choose to use the STATUS mechanism to determine if a network is ready.

Status was initially proposed in #859

TODO:

  • Add STATUS subsection in Execution flow (Section 3). This needs to be restructured for GC as well.

@squeed squeed added this to the CNI v1.1 milestone Jun 19, 2023
@coveralls
Copy link

coveralls commented Jun 19, 2023

Coverage Status

coverage: 71.573%. remained the same when pulling 509c490 on squeed:spec-status into 5968d61 on containernetworking:main.

@squeed
Copy link
Member Author

squeed commented Jul 3, 2023

hey @danwinship, might you have some time to look at this?

SPEC.md Show resolved Hide resolved
@squeed squeed marked this pull request as ready for review July 3, 2023 15:45
@aojea
Copy link

aojea commented Jul 3, 2023

/cc

SPEC.md Show resolved Hide resolved
SPEC.md Outdated Show resolved Hide resolved
SPEC.md Show resolved Hide resolved
SPEC.md Show resolved Hide resolved
SPEC.md Show resolved Hide resolved
SPEC.md Outdated Show resolved Hide resolved
This adds a new verb, STATUS, which indicates whether or not a plugin is
ready to accept ADD requests. Runtimes may choose to use the STATUS
mechanism to determine if a network is ready.

Signed-off-by: Casey Callendrello <c1@caseyc.net>
@squeed
Copy link
Member Author

squeed commented Dec 4, 2023

As discussed in the meeting, this is ready to merge.

@squeed squeed merged commit 9c19f13 into containernetworking:main Dec 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants