Add Marshal function in Result/NetConf to omit empty value #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1061123
force-pushed
the
json-remove-dns
branch
2 times, most recently
from
2aa3157
to
f4ecee9
Compare
cyclinder
reviewed
Nov 1, 2023
s1061123
force-pushed
the
json-remove-dns
branch
from
f4ecee9
to
b4cc410
Compare
dcbw
reviewed
Nov 20, 2023
s1061123
force-pushed
the
json-remove-dns
branch
3 times, most recently
from
14cfe74
to
4ebc03d
Compare
s1061123
force-pushed
the
json-remove-dns
branch
from
4ebc03d
to
82f2ca0
Compare
s1061123
force-pushed
the
json-remove-dns
branch
from
82f2ca0
to
e203d72
Compare
squeed
approved these changes
Dec 18, 2023
This change fix to avoid empty DNS field in NetConf/Result if DNS is empty. Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
s1061123
force-pushed
the
json-remove-dns
branch
from
e203d72
to
d1276f1
Compare
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fix to avoid empty DNS/IPAM field in NetConf/Result if DNS is empty.