Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line environment files are not correctly processed #908

Closed
hedayat opened this issue Apr 8, 2024 · 1 comment
Closed

Multi-line environment files are not correctly processed #908

hedayat opened this issue Apr 8, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@hedayat
Copy link
Contributor

hedayat commented Apr 8, 2024

Describe the bug
For environment files, podman-compose passes them to podman with its --env-file option. However, podman/docker and docker-compose process environment files differently: podman/docker doesn't support multi-line environment files, while docker compose supports them (containers/podman#18724 (comment)).

Expected behavior
Properly support multi-line env files

Actual behavior
Just passes env-files to podman, which doesn't support multi-line env vars, as apparently docker also doesn't support them too.

** Implementation **
I found that it can be easily implemented (parse env file with dotenv, and pass variables to podman), and I'll open a PR to fix it too.

@hedayat hedayat added the bug Something isn't working label Apr 8, 2024
hedayat added a commit to hedayat/podman-compose that referenced this issue Apr 8, 2024
Signed-off-by: Hedayat Vatankhah <hedayat.fwd@gmail.com>
hedayat added a commit to hedayat/podman-compose that referenced this issue May 7, 2024
Signed-off-by: Hedayat Vatankhah <hedayat.fwd@gmail.com>
mokibit pushed a commit to mokibit/podman-compose that referenced this issue May 26, 2024
Signed-off-by: Hedayat Vatankhah <hedayat.fwd@gmail.com>
mokibit pushed a commit to mokibit/podman-compose that referenced this issue May 26, 2024
Signed-off-by: Hedayat Vatankhah <hedayat.fwd@gmail.com>
p12tic pushed a commit to mokibit/podman-compose that referenced this issue May 28, 2024
Signed-off-by: Hedayat Vatankhah <hedayat.fwd@gmail.com>
@p12tic p12tic closed this as completed in f3e9a96 May 28, 2024
@mokibit
Copy link
Contributor

mokibit commented Jun 3, 2024

Fixed in #949.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants