Add support for multi-line environment files #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
reviewed
May 26, 2024
mokibit
force-pushed
the
multiline-env-file
branch
from
2453dd2
to
8677268
Compare
|
@mokibit |
p12tic
force-pushed
the
multiline-env-file
branch
from
8677268
to
e82bc21
Compare
Signed-off-by: Hedayat Vatankhah <hedayat.fwd@gmail.com>
mokibit
force-pushed
the
multiline-env-file
branch
from
e82bc21
to
9242108
Compare
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
Signed-off-by: Monika Kairaityte <monika@kibit.lt>
mokibit
force-pushed
the
multiline-env-file
branch
from
9242108
to
2e8ed2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for several multi-line environment files.
PR fixes issue #908.
Credit for actual solution goes to @hedayat. I only added tests as code reviewer @p12tic requested.
From #909:
"TBH, I don't find the part of compose spec which specifies this. Actually, it might not be according to the spec. However, this is what docker compose supports... !"