Add --network=none if network_mode: none is set
#1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
requested changes
Jul 15, 2024
|
The DCO test fails because it asks for "Signed-off-by" line in the commit description. It is generated by |
|
See e.g. 8505009 |
nerilex
force-pushed
the
main
branch
2 times, most recently
from
69704bf
to
f5672c1
Compare
|
Thanks for reminding me :). |
p12tic
approved these changes
Jul 16, 2024
…#1001. Signed-off-by: bg <bg@nerilex.org>
|
Rebased and squashed the commits into one. Test changes should come together with the feature in the same commit |
p12tic
changed the title
--network=none if network_mode: none is set; fixes #1001.--network=none if network_mode: none is set
|
Added newsfragment. |
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is response / fix for #1001.