Fix extend be runnable using an empty service (placeholder) #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natanael Arndt <arndtn@gmail.com>
Signed-off-by: Natanael Arndt <arndtn@gmail.com>
| @@ -1375,7 +1375,11 @@ def resolve_extends(services, service_names, environ): | |||
| content = content["services"] | |||
| subdirectory = os.path.dirname(filename) | |||
| content = rec_subs(content, environ) | |||
| from_service = content.get(from_service_name, {}) | |||
There was a problem hiding this comment.
just make it like this
from_service = content.get(from_service_name, {}) or {}
Signed-off-by: Natanael Arndt <arndtn@gmail.com>
white-gecko
force-pushed
the
feature/support_extends_with_empty_service
branch
from
7f21c79
to
a59fe73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the case of #734 as test and fix it.
Fix #734.