Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added handling pid option #765

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Added handling pid option #765

merged 1 commit into from
Mar 9, 2024

Conversation

timocov
Copy link
Contributor

@timocov timocov commented Sep 9, 2023

Fixes #554

@timocov timocov marked this pull request as ready for review September 9, 2023 22:21
p12tic
p12tic requested changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR.

Could unit tests be added? There's an example in pytests/test_container_to_args.py.

@timocov
Added handling pid option
91d316f 
Fixes #554

Signed-off-by: Evgeniy Timokhov <timocov@gmail.com>
@timocov
Copy link
Contributor Author

timocov commented Mar 9, 2024

@p12tic added tests and rebased onto main.

@timocov timocov requested a review from p12tic March 9, 2024 16:25
p12tic
p12tic approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@p12tic p12tic merged commit f2f2f15 into containers:main Mar 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p12tic p12tic p12tic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignores pid: host
2 participants
@timocov @p12tic