Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --in-pod parameter for systemd commands #772

Closed
wants to merge 1 commit into from

Conversation

ttsak
Copy link

@ttsak ttsak commented Sep 16, 2023

systemd scripts depend an a pod to exist but this is not created unless the in-pod parameter is added

systemd scripts depend an a pod to exist but this is not created unless the in-pod parameter is added

Signed-off-by: Triantafyllos <ttsak@hotmail.com>
@RalfSchwiete
Copy link

Hi,

really nice work the podman-composer. IMHO it shouldn't be
ExecStartPre=-{script} --in-pod %i up --no-start
but
ExecStartPre=-{script} --in-pod pod_%i up --no-start
in the unit file.

Also it might be good to have a "ExecStopPost" line to remove the pod:
ExecStopPost=/usr/bin/podman pod rm pod_%i

Thank you for your great work,
Ralf

@p12tic
Copy link
Collaborator

p12tic commented Jun 26, 2024

--in-pod is now default, so this PR is no longer needed. Thanks a lot for caring about this feature.

@p12tic p12tic closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants