fix(ipam_driver): do not pass --ipam-driver option when value set to … #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fccagou
force-pushed
the
fix-ipam-driver-default
branch
from
9f20aec
to
c9d2092
Compare
|
Sorry for the push force. |
fccagou
force-pushed
the
fix-ipam-driver-default
branch
2 times, most recently
from
7922049
to
23a45c8
Compare
p12tic
reviewed
Mar 8, 2024
podman_compose.py
Outdated
| @@ -762,7 +762,7 @@ async def assert_cnt_nets(compose, cnt): | |||
| args.extend(("--opt", f"{key}={value}")) | |||
| ipam = net_desc.get("ipam", None) or {} | |||
| ipam_driver = ipam.get("driver", None) | |||
| if ipam_driver: | |||
| if ipam_driver and ipam_driver not in ("default"): | |||
There was a problem hiding this comment.
I think the code would be clearer if we compared using !=. Also I think there's a bug here, because ("default") is not a tuple. ("default",) would be a tuple.
There was a problem hiding this comment.
You are right, the missing ',' is strange because my tests worked ...
Yes, we can compare using !=.
I do a patch with it.
p12tic
requested changes
Mar 8, 2024
fccagou
force-pushed
the
fix-ipam-driver-default
branch
3 times, most recently
from
7b8cebc
to
7de2168
Compare
fixes containers#852. Signed-off-by: fccagou <me@fccagou.fr>
p12tic
force-pushed
the
fix-ipam-driver-default
branch
from
7de2168
to
c23a8b2
Compare
|
Rebased and adjusted commit message. |
|
@fccagou Sorry for the delay. I haven't noticed that you've force pushed with the fixes. |
p12tic
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…default
podman returns unsupported ipam driver "default" when
--imap-driver defaultparameter is passed.So, when ipam driver is set to "default" in docker-compose.yml, --imap-driver must not be used when podman is called.