Fix support for older python versions #887
Conversation
.editorconfig
Outdated
| charset = utf-8 | ||
| trim_trailing_whitespace = true | ||
| insert_final_newline = true | ||
| max_line_length = 120 |
There was a problem hiding this comment.
Let's keep line length at 100, it's what ruff is configured with now.
| coverage combine | ||
| coverage report | ||
| env: | ||
| TESTS_DEBUG: 1 |
There was a problem hiding this comment.
This is needed to spot errors in case tests fail in CI.
There was a problem hiding this comment.
The failing tests usually print a nice log in the end. Is that not sufficient?
| @@ -21,11 +26,13 @@ jobs: | |||
| python -m pip install --upgrade pip | |||
| if [ -f requirements.txt ]; then pip install -r requirements.txt; fi | |||
| if [ -f test-requirements.txt ]; then pip install -r test-requirements.txt; fi | |||
There was a problem hiding this comment.
If pylint is added to CI then it should be added to test-requirements.txt for installation.
|
In
|
|
Overall looks good. I stand corrected, can bring back pylint. |
baszoetekouw
force-pushed
the
fix-oldpython
branch
from
e4338ab
to
63d0be0
Compare
|
Thanks for the feedback! This should fix the outstanding issues. |
|
Match editorconfig max line length with ruff config should be part of |
Signed-off-by: Bas Zoetekouw <bas.zoetekouw@surf.nl>
Signed-off-by: Bas Zoetekouw <bas.zoetekouw@surf.nl>
Signed-off-by: Bas Zoetekouw <bas.zoetekouw@surf.nl>
Signed-off-by: Bas Zoetekouw <bas.zoetekouw@surf.nl>
Signed-off-by: Bas Zoetekouw <bas.zoetekouw@surf.nl>
Signed-off-by: Bas Zoetekouw <bas.zoetekouw@surf.nl>
Signed-off-by: Bas Zoetekouw <bas.zoetekouw@surf.nl>
As some python module names are not proper english words Signed-off-by: Bas Zoetekouw <bas.zoetekouw@surf.nl>
baszoetekouw
force-pushed
the
fix-oldpython
branch
from
3652246
to
da63048
Compare
|
done! |
This PR replaces #869
It retains the changes needed to support older python versions.
Also, it makes some changes to the CI, notably:
As a side note: because coverage now is checked in the CI, it might make sense to enable a tool like https://codecov.io/, which provides a nice web interface showing where coverage is missing, and also adds an automatic CI check to check that new PRs don't decrease coverage.