Skip to content

Commit

Permalink
[#3601] Feat-630: Upgrade AWS lambda nodejs version to nodejs16.x
Browse files Browse the repository at this point in the history
### What is the feature/fix?
Upgrade the node version to 16.x for AWS lambda

convox/issues-private#630

### Add screenshot or video (optional)

![Screenshot from 2022-10-26 00-34-22](https://user-images.githubusercontent.com/12232198/197854129-d8cef925-e00e-4cab-ae90-228b69e9b0d8.png)

### Does it has a breaking change?
no

### How to use/test it?
Deploy a rack from this branch version

### Checklist
- [ ] New coverage tests
- [x] Unit tests passing
- [x] E2E tests passing
- [x] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
  • Loading branch information
nightfury1204 committed Oct 28, 2022
1 parent 96c587c commit cd9f97b
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion provider/aws/formation/app.json.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@
"Properties": {
"Handler": "index.handler",
"Role": { "Fn::GetAtt": [ "TimerRole", "Arn" ] },
"Runtime": "nodejs14.x",
"Runtime": "nodejs16.x",
"Timeout": 60,
"Code": {
"ZipFile": { "Fn::Join": [ "\n", [
Expand Down
4 changes: 2 additions & 2 deletions provider/aws/formation/g1/app.json.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"Handler": "index.external",
"MemorySize": "128",
"Role": { "Fn::GetAtt": [ "CustomTopicRole", "Arn" ] },
"Runtime": "nodejs14.x",
"Runtime": "nodejs16.x",
"Timeout": "300"
}
},
Expand Down Expand Up @@ -715,7 +715,7 @@
"Properties": {
"Handler": "index.handler",
"Role": { "Fn::GetAtt": [ "CronRole", "Arn" ] },
"Runtime": "nodejs14.x",
"Runtime": "nodejs16.x",
"Timeout": 50,
"Code": {
"ZipFile": { "Fn::Join": ["\n", [
Expand Down
2 changes: 1 addition & 1 deletion provider/aws/formation/rack.json
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@
"Handler": "index.external",
"MemorySize": "128",
"Role": { "Fn::GetAtt": [ "CustomTopicRole", "Arn" ] },
"Runtime": "nodejs14.x",
"Runtime": "nodejs16.x",
"Timeout": "300",
"VpcConfig": {
"SecurityGroupIds": [
Expand Down
2 changes: 1 addition & 1 deletion provider/aws/templates/resource/webhook.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"Environment": { "Variables": { "WEBHOOK_URL": { "Ref": "Url" } } },
"Handler": "index.handler",
"Role": { "Fn::GetAtt": [ "ForwarderRole", "Arn" ] },
"Runtime": "nodejs14.x",
"Runtime": "nodejs16.x",
"Timeout": "10"
}
},
Expand Down
2 changes: 1 addition & 1 deletion provider/kaws/formation/rack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ Resources:
}
Handler: index.main
Role: !GetAtt DomainMapperRole.Arn
Runtime: nodejs14.x
Runtime: nodejs16.x
DomainMapperRole:
Type: AWS::IAM::Role
Condition: BaseDomainBlank
Expand Down

0 comments on commit cd9f97b

Please sign in to comment.