chore: compress and cache favicon.ico (#309)

conwnet · May 22, 2021 · 63bb55b · 63bb55b
1 parent 0a422ce
commit 63bb55b
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 8 deletions.
diff --git a/resources/favicon-dark.ico b/resources/favicon-dark.ico
diff --git a/resources/favicon-dark.svg b/resources/favicon-dark.svg
diff --git a/resources/favicon-light.ico b/resources/favicon-light.ico
diff --git a/resources/favicon-light.svg b/resources/favicon-light.svg
diff --git a/resources/favicon.ico b/resources/favicon.ico
diff --git a/resources/index-dev-vscode.html b/resources/index-dev-vscode.html
@@ -12,8 +12,8 @@
 		<!-- VS Code Extensions Configuration -->
 		<meta id="vscode-workbench-builtin-extensions" data-settings="[]" />
 		<!-- Workbench Icon/Manifest/CSS -->
-		<link rel="icon" media="(prefers-color-scheme:light)" href="/favicon-light.ico" type="image/x-icon">
-		<link rel="icon" media="(prefers-color-scheme:dark)" href="/favicon-dark.ico" type="image/x-icon">
+		<link rel="icon" media="(prefers-color-scheme:light)" href="/favicon-light.svg" type="image/svg+xml">
+		<link rel="icon" media="(prefers-color-scheme:dark)" href="/favicon-dark.svg" type="image/svg+xml">
 		<link rel="manifest" href="/manifest.json" />
 		<title>GitHub1s</title>
 	</head>

diff --git a/resources/index-hash.html b/resources/index-hash.html
@@ -12,8 +12,8 @@
 		<!-- VS Code Extensions Configuration -->
 		<meta id="vscode-workbench-builtin-extensions" data-settings="[]" />
 		<!-- Workbench Icon/Manifest/CSS -->
-		<link rel="icon" media="(prefers-color-scheme:light)" href="/favicon-light.ico" type="image/x-icon">
-		<link rel="icon" media="(prefers-color-scheme:dark)" href="/favicon-dark.ico" type="image/x-icon">
+		<link rel="icon" media="(prefers-color-scheme:light)" href="/favicon-light.svg" type="image/svg+xml">
+		<link rel="icon" media="(prefers-color-scheme:dark)" href="/favicon-dark.svg" type="image/svg+xml">
 		<link rel="preload" href="/static/{STATIC_HASH_CODE}/vscode/vs/workbench/workbench.web.api.css" as="style">
 		<link rel="preload" href="/static/{STATIC_HASH_CODE}/vscode/vs/code/browser/workbench/workbench.css" as="style">
 		<link rel="manifest" href="/manifest.json" />

diff --git a/resources/index.html b/resources/index.html
@@ -12,8 +12,8 @@
 		<!-- VS Code Extensions Configuration -->
 		<meta id="vscode-workbench-builtin-extensions" data-settings="[]" />
 		<!-- Workbench Icon/Manifest/CSS -->
-		<link rel="icon" media="(prefers-color-scheme:light)" href="/favicon-light.ico" type="image/x-icon">
-		<link rel="icon" media="(prefers-color-scheme:dark)" href="/favicon-dark.ico" type="image/x-icon">
+		<link rel="icon" media="(prefers-color-scheme:light)" href="/favicon-light.svg" type="image/svg+xml">
+		<link rel="icon" media="(prefers-color-scheme:dark)" href="/favicon-dark.svg" type="image/svg+xml">
 		<link rel="preload" href="/static/vscode/vs/workbench/workbench.web.api.css" as="style">
 		<link rel="preload" href="/static/vscode/vs/code/browser/workbench/workbench.css" as="style">
 		<link rel="manifest" href="/manifest.json" />

diff --git a/scripts/package/copy-resources.sh b/scripts/package/copy-resources.sh
@@ -13,7 +13,7 @@ function main() {
 	else
 		cp resources/index.html dist/index.html
 	fi
-	cp resources/*.ico dist
+	cp resources/favicon* dist
 	cp resources/manifest.json dist
 
 	echo "copy resources done!"

diff --git a/vercel.json b/vercel.json
@@ -28,7 +28,7 @@
       ]
     },
     {
-      "source": "/favicon(-dark|-light)?.ico",
+      "source": "/favicon(-dark|-light)?\\.(ico|svg)",
       "headers": [
         {
           "key": "Cache-Control",