Fix code scanning alert no. 20: Client-side cross-site scripting #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cooljeanius/ghidra/security/code-scanning/20
To fix the cross-site scripting vulnerability, we need to sanitize the user-provided input before assigning it to
this.notes
and subsequently setting it asinnerHTML
. TheDOMPurify
library, which is already included in the script, can be used for this purpose. This ensures that any potentially harmful scripts are removed from the input.DOMPurify
before assigning it tothis.notes
and setting it asinnerHTML
.DOMPurify.sanitize(argv[1])
instead of directly assigningargv[1]
tothis.notes
.Dz.onmessage
function to include the sanitization step.Suggested fixes powered by Copilot Autofix. Review carefully before merging.