Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document behavior of generating destination path when copying #1498

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

phinate
Copy link

@phinate phinate commented Feb 5, 2024

Documents #1497.

Copy link
Contributor

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions in case other maintainers wish to accept this change.

README.md Outdated Show resolved Hide resolved
docs/generating.md Outdated Show resolved Hide resolved
phinate and others added 2 commits February 5, 2024 12:58
Co-authored-by: Timothée Mazzucotelli <dev@pawamoy.fr>
Co-authored-by: Timothée Mazzucotelli <dev@pawamoy.fr>
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yajo yajo enabled auto-merge (squash) February 11, 2024 13:55
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.27%. Comparing base (5f7dc40) to head (55aa924).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1498      +/-   ##
==========================================
- Coverage   97.46%   97.27%   -0.20%     
==========================================
  Files          48       48              
  Lines        4537     4543       +6     
==========================================
- Hits         4422     4419       -3     
- Misses        115      124       +9     
Flag Coverage Δ
unittests 97.27% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yajo yajo added this to the Soon milestone Feb 20, 2024
@yajo
Copy link
Member

yajo commented Feb 20, 2024

There are formatting issues. Please run poetry run poe lint and push the new changes.

auto-merge was automatically disabled February 20, 2024 08:53

Head branch was pushed to by a user without write access

Comment on lines -80 to +94
```python
from copier import run_copy
```python
from copier import run_copy

# Create a project from a local path
run_copy("path/to/project/template", "path/to/destination")
# Create a project from a local path
run_copy("path/to/project/template", "path/to/destination")

# Or from a Git URL.
run_copy("https://github.com/copier-org/copier.git", "path/to/destination")
# Or from a Git URL.
run_copy("https://github.com/copier-org/copier.git", "path/to/destination")

# You can also use "gh:" as a shortcut of "https://github.com/"
run_copy("gh:copier-org/copier.git", "path/to/destination")
# You can also use "gh:" as a shortcut of "https://github.com/"
run_copy("gh:copier-org/copier.git", "path/to/destination")

# Or "gl:" as a shortcut of "https://gitlab.com/"
run_copy("gl:copier-org/copier.git", "path/to/destination")
```
# Or "gl:" as a shortcut of "https://gitlab.com/"
run_copy("gl:copier-org/copier.git", "path/to/destination")
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these indentation changes are necessary.

run_copy("gl:copier-org/copier.git", "path/to/destination")
```

If `path/to/destination` doesn't exist, Copier will create the directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just leave it documented in ˋgenerating.mdˋ. This way, the README is shorter. It's not something with so much importance so as to live in the README IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants