Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NIP-17 UX #387

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Improve NIP-17 UX #387

merged 7 commits into from
Jul 19, 2024

Conversation

SamSamskies
Copy link
Contributor

resolves #378

single recipient where current user doesn't have inbox relays
Screenshot 2024-07-19 at 10 36 19 AM

no nip-17 toggle for group messages
Screenshot 2024-07-19 at 10 36 58 AM

disable ability to start a group message if not all group members have inbox relays
Screenshot 2024-07-19 at 10 38 04 AM

display confirm screen when in group chat and at least one person is missing inbox relays
Screenshot 2024-07-19 at 10 37 28 AM

Screenshot 2024-07-19 at 10 46 31 AM

- the toggle is now set to nip-04 and disabled if the current user does not have any inbox relays
- on toggle hover, a tooltip with a CTA to set up inbox relays is displayed
- on CTA click, relay settings modal is displayed so that the user can set up inbox relays
@SamSamskies SamSamskies changed the title Improve nip 17 ux Improve nip-17 UX Jul 19, 2024
@SamSamskies SamSamskies changed the title Improve nip-17 UX Improve NIP-17 UX Jul 19, 2024
@staab staab merged commit fd8b3dc into coracle-social:dev Jul 19, 2024
@staab
Copy link
Collaborator

staab commented Jul 19, 2024

Merged and zapped 🫡

Made a couple changes here: 1adbca1

  • I didn't know about Intl.ListFormat. I used my usual library function displayList instead, but opened Get rid of displayList #388
  • I tweaked copy to include more information about who is missing inbox relays, and a clear click target to fix that.
  • Removed some convoluted logic for figuring out which pubkeys had inbox relays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants