Add missing RBAC for alertmanagerconfigs and outboundwebhooks (#153)

coralogix · Sep 25, 2024 · 156f772 · 156f772
1 parent 1e8342a
commit 156f772
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 16 deletions.
diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml
@@ -2,7 +2,6 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
- creationTimestamp: null
  name: manager-role
 rules:
 - apiGroups:
@@ -34,7 +33,7 @@ rules:
 - apiGroups:
  - coralogix.com
  resources:
- - recordingrulegroupsets
+ - outboundwebhooks
  verbs:
  - create
  - delete
@@ -46,21 +45,21 @@ rules:
 - apiGroups:
  - coralogix.com
  resources:
- - recordingrulegroupsets/finalizers
+ - outboundwebhooks/finalizers
  verbs:
  - update
 - apiGroups:
  - coralogix.com
  resources:
- - recordingrulegroupsets/status
+ - outboundwebhooks/status
  verbs:
  - get
  - patch
  - update
 - apiGroups:
  - coralogix.com
  resources:
- - rulegroups
+ - recordingrulegroupsets
  verbs:
  - create
  - delete
@@ -72,21 +71,21 @@ rules:
 - apiGroups:
  - coralogix.com
  resources:
- - rulegroups/finalizers
+ - recordingrulegroupsets/finalizers
  verbs:
  - update
 - apiGroups:
  - coralogix.com
  resources:
- - rulegroups/status
+ - recordingrulegroupsets/status
  verbs:
  - get
  - patch
  - update
 - apiGroups:
- - coralogix.coralogix.com
+ - coralogix.com
  resources:
- - outboundwebhooks
+ - rulegroups
  verbs:
  - create
  - delete
@@ -96,19 +95,27 @@ rules:
  - update
  - watch
 - apiGroups:
- - coralogix.coralogix.com
+ - coralogix.com
  resources:
- - outboundwebhooks/finalizers
+ - rulegroups/finalizers
  verbs:
  - update
 - apiGroups:
- - coralogix.coralogix.com
+ - coralogix.com
  resources:
- - outboundwebhooks/status
+ - rulegroups/status
  verbs:
  - get
  - patch
  - update
+- apiGroups:
+ - monitoring.coreos.com
+ resources:
+ - alertmanagerconfigs
+ verbs:
+ - get
+ - list
+ - watch
 - apiGroups:
  - monitoring.coreos.com
  resources:

diff --git a/controllers/alertmanagerconfig_controller.go b/controllers/alertmanagerconfig_controller.go
@@ -25,6 +25,7 @@ import (
 )
 
 //+kubebuilder:rbac:groups=monitoring.coreos.com,resources=prometheusrules,verbs=get;list;watch
+//+kubebuilder:rbac:groups=monitoring.coreos.com,resources=alertmanagerconfigs,verbs=get;list;watch
 
 //+kubebuilder:rbac:groups=coralogix.com,resources=recordingrulegroupsets,verbs=get;list;watch;create;update;patch;delete
 //+kubebuilder:rbac:groups=coralogix.com,resources=recordingrulegroupsets/status,verbs=get;update;patch

diff --git a/controllers/alphacontrollers/outboundwebhook_controller.go b/controllers/alphacontrollers/outboundwebhook_controller.go
@@ -47,9 +47,9 @@ type OutboundWebhookReconciler struct {
  Scheme *runtime.Scheme
 }
 
-//+kubebuilder:rbac:groups=coralogix.coralogix.com,resources=outboundwebhooks,verbs=get;list;watch;create;update;patch;delete
-//+kubebuilder:rbac:groups=coralogix.coralogix.com,resources=outboundwebhooks/status,verbs=get;update;patch
-//+kubebuilder:rbac:groups=coralogix.coralogix.com,resources=outboundwebhooks/finalizers,verbs=update
+//+kubebuilder:rbac:groups=coralogix.com,resources=outboundwebhooks,verbs=get;list;watch;create;update;patch;delete
+//+kubebuilder:rbac:groups=coralogix.com,resources=outboundwebhooks/status,verbs=get;update;patch
+//+kubebuilder:rbac:groups=coralogix.com,resources=outboundwebhooks/finalizers,verbs=update
 
 var (
  outboundWebhookFinalizerName = "outbound-webhook.coralogix.com/finalizer"