[FIX] empty rule group (#118)

Signed-off-by: Nicolas Takashi <nicolas.takashi@coralogix.com>
coralogix · Jul 29, 2024 · 81b7d8c · 81b7d8c
1 parent d832ea1
commit 81b7d8c
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/controllers/prometheusrule_controller.go b/controllers/prometheusrule_controller.go
@@ -115,6 +115,7 @@ func (r *PrometheusRuleReconciler) convertPrometheusRuleRecordingRuleToCxRecordi
  return fmt.Errorf("received an error while trying to get RecordingRuleGroupSet CRD: %w", err)
  }
 
+ recordingRuleGroupSet.Spec = recordingRuleGroupSetSpec
  if err := r.Client.Update(ctx, recordingRuleGroupSet); err != nil {
  return fmt.Errorf("received an error while trying to update RecordingRuleGroupSet CRD: %w", err)
  }
@@ -212,11 +213,13 @@ func prometheusRuleToRecordingRuleToRuleGroupSet(log logr.Logger, prometheusRule
  interval = int32(duration.Seconds())
  }
 
- groups = append(groups, coralogixv1alpha1.RecordingRuleGroup{
- Name: group.Name,
- IntervalSeconds: interval,
- Rules: prometheusInnerRulesToCoralogixInnerRules(group.Rules),
- })
+ if rules := prometheusInnerRulesToCoralogixInnerRules(group.Rules); len(rules) > 0 {
+ groups = append(groups, coralogixv1alpha1.RecordingRuleGroup{
+ Name: group.Name,
+ IntervalSeconds: interval,
+ Rules: rules,
+ })
+ }
  }
 
  return coralogixv1alpha1.RecordingRuleGroupSetSpec{