[REFACTOR] prometheus rules reconcile #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolastakashi
force-pushed
the
refactor/improving-prometheus-rules-reconciliation
branch
from
73c5c52
to
c0e9388
Compare
Signed-off-by: Nicolas Takashi <nicolas.takashi@coralogix.com>
nicolastakashi
force-pushed
the
refactor/improving-prometheus-rules-reconciliation
branch
from
c0e9388
to
6a798df
Compare
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
nicolastakashi
deleted the
refactor/improving-prometheus-rules-reconciliation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding WithEventFilter to allow us reduce the amount of resources we're reconciling, if the object didn't match the reconcile rule it will not be added to the work queue.
REf: https://stuartleeks.com/posts/kubebuilder-event-filters-part-1-delete/