Refactoring record group rule set controller #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We must waiting #116 to be merged first and rebase it after merge. |
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
OrNovo
previously approved these changes
Jul 29, 2024
nicolastakashi
force-pushed
the
refactory/record-group-rule-set-controller
branch
from
d4d0f36
to
bf82241
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
nicolastakashi
force-pushed
the
refactory/record-group-rule-set-controller
branch
2 times, most recently
from
3b65a2c
to
6e43b54
Compare
nicolastakashi
force-pushed
the
refactory/record-group-rule-set-controller
branch
from
6e43b54
to
8a704c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm refactoring the record group rule set in order to fix some identified issues to reconcile rules and improve maintainability.