Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing prometheusRule_controller logic #134

Merged
merged 2 commits into from
Aug 16, 2024
Merged

fixing prometheusRule_controller logic #134

merged 2 commits into from
Aug 16, 2024

Conversation

OrNovo
Copy link
Contributor

@OrNovo OrNovo commented Aug 15, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Previous Coverage 14.4% of statements
New Coverage 14.6% of statements
Patch Coverage 82.8% of changed statements (24/29)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@OrNovo OrNovo marked this pull request as ready for review August 15, 2024 12:39
@OrNovo OrNovo requested a review from a team as a code owner August 15, 2024 12:39
@OrNovo OrNovo merged commit f2adae7 into main Aug 16, 2024
7 of 8 checks passed
@OrNovo OrNovo deleted the refactoring_prometheusRule_controller branch August 16, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oded-dd oded-dd oded-dd approved these changes

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrNovo @oded-dd