Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outgoing-webhooks validation #178

Merged
merged 21 commits into from
Oct 17, 2024
Merged

outgoing-webhooks validation #178

merged 21 commits into from
Oct 17, 2024

Conversation

OrNovo
Copy link
Contributor

@OrNovo OrNovo commented Oct 14, 2024

IAC-224 CXO: Validation Webhooks for CRDs

@OrNovo OrNovo requested a review from a team as a code owner October 14, 2024 10:36
Copy link

gitguardian bot commented Oct 14, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14149094 Triggered Generic High Entropy Secret 1e3e9e9 config/manager/manager.yaml View secret
14149094 Triggered Generic High Entropy Secret 16dcc54 config/manager/manager.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

github-actions bot commented Oct 14, 2024

Previous Coverage 26.8% of statements
New Coverage 26.8% of statements
Patch Coverage 0.0% of changed statements (0/0)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@assafad1
Copy link
Contributor

assafad1 commented Oct 16, 2024

@OrNovo Please consider adding testcases to e2e/outbound_webhook_test.go, or in a new file, to validate the new functionality (even in a follow-up).

@OrNovo
Copy link
Contributor Author

OrNovo commented Oct 17, 2024

@OrNovo Please consider adding testcases to e2e/outbound_webhook_test.go, or in a new file, to validate the new functionality (even in a follow-up).

I resolved the issued you mentioned. The e2e-tests will be added on a different PR.

Copy link
Contributor

@assafad1 assafad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OrNovo Thanks for addressing my comments, really nice work here!

@OrNovo OrNovo merged commit 4771b69 into main Oct 17, 2024
7 of 9 checks passed
@OrNovo OrNovo deleted the outgoinwebhooks-validation branch October 17, 2024 12:49
Copy link
Contributor

🎉 This PR is included in version 0.2.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants