[FIX] nil memory pointer std alerts #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
approved these changes
Jul 28, 2023
OrNovo
reviewed
Jul 28, 2023
| @@ -367,6 +367,9 @@ func flattenStandardCondition(condition *alerts.AlertCondition) coralogixv1alpha | |||
| var standardCondition coralogixv1alpha1.StandardConditions | |||
| var conditionParams *alerts.ConditionParameters | |||
|
|
|||
| standardCondition.Threshold = new(int) | |||
There was a problem hiding this comment.
This is relevant for Less, More, and MoreThanUsual (for Immediate it can cause a bug if it won't be nil).
| @@ -367,6 +367,9 @@ func flattenStandardCondition(condition *alerts.AlertCondition) coralogixv1alpha | |||
| var standardCondition coralogixv1alpha1.StandardConditions | |||
| var conditionParams *alerts.ConditionParameters | |||
|
|
|||
| standardCondition.Threshold = new(int) | |||
| standardCondition.TimeWindow = new(coralogixv1alpha1.TimeWindow) | |||
There was a problem hiding this comment.
This is relevant for Less, More, and (for Immediate and MoreThanUsual it can cause a bug if it won't be nil).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm fixing issues we faced with nil pointer addresses.