Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch - saving external IDs immediately #38

Merged
merged 1 commit into from
Aug 1, 2023
Merged

patch - saving external IDs immediately #38

merged 1 commit into from
Aug 1, 2023

Conversation

OrNovo
Copy link
Contributor

@OrNovo OrNovo commented Jul 30, 2023

No description provided.

@OrNovo OrNovo requested a review from a team as a code owner July 30, 2023 08:35
povilasv
povilasv reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@povilasv povilasv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests updated / added ? How do we know if it works?

@OrNovo
Copy link
Contributor Author

OrNovo commented Jul 31, 2023

No tests updated / added ? How do we know if it works?

@povilasv The only way that I can think of to test it, is to cause a failure on the flatten step (expand the CR status after the resource was create in Coralogix), and checking if the resources are created over and over again.
So I tested it manually and it looks fine, but do you have better idea?

@OrNovo OrNovo requested a review from povilasv July 31, 2023 13:30
@OrNovo OrNovo merged commit 28ff2cd into main Aug 1, 2023
5 checks passed
@OrNovo OrNovo deleted the saving_external_id_immediately branch August 1, 2023 10:24
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

🎉 This PR is included in version 0.1.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@povilasv povilasv povilasv approved these changes

@ArthurSens ArthurSens Awaiting requested review from ArthurSens

@matej-g matej-g Awaiting requested review from matej-g

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrNovo @povilasv