Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove group-by from promql alert spec #55

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

OrNovo
Copy link
Contributor

@OrNovo OrNovo commented Aug 22, 2023

Remove group-by array from promql-alert spec since when filling group-by through the query (e.g.

searchQuery: |-
     sum(
      max_over_time(aws_autoscaling_group_in_service_instances_average[15m] offset 30m) 
      / 
      aws_autoscaling_group_total_instances_average offset 30m
     ) **by (auto_scaling_group_name, region, cluster, env)**

), the alerts-API returns the group-by in the designated field as well (

groupBy: [auto_scaling_group_name, region, cluster, env]

), which causes a diff between the spec and the status and an attempt to update the CR forever.

@OrNovo OrNovo requested a review from a team as a code owner August 22, 2023 10:39
@github-actions
Copy link
Contributor

New Coverage 1.2% of statements
Patch Coverage 0.0% of changed statements (0/0)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@OrNovo OrNovo merged commit 9ad7c19 into main Aug 22, 2023
7 of 8 checks passed
@OrNovo OrNovo deleted the promql_remove_group-by branch August 22, 2023 14:23
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.1.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.1.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

2 similar comments
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.1.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.1.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants