Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ms to timestamp #21

Merged
merged 2 commits into from
Jun 10, 2024
Merged

add ms to timestamp #21

merged 2 commits into from
Jun 10, 2024

Conversation

DimaGolomozy
Copy link
Contributor

@DimaGolomozy DimaGolomozy commented May 15, 2024 •
edited
Loading

@daidokoro
please have a look.. we saw that the sdk is missing the ms in the timestamp.
it causes disorder on logs send on the same second.

@DimaGolomozy
Copy link
Contributor Author

hi @daidokoro
please help review.. this ms in the timestamp is kinda important.
missing that ms causes log A to appear before log B. when log B should be after log A

@DimaGolomozy
Copy link
Contributor Author

@daidokoro @EldarAliiev please have a look on the PR

@royfur royfur requested a review from daidokoro June 10, 2024 07:39
daidokoro
daidokoro approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DimaGolomozy ,

LGTM

@royfur royfur merged commit 61ce46e into coralogix:master Jun 10, 2024
3 checks passed
@DimaGolomozy DimaGolomozy deleted the fixup-timestamp-ms branch September 3, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daidokoro daidokoro daidokoro approved these changes

Assignees

@daidokoro daidokoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimaGolomozy @daidokoro @royfur