sync time only if buffer is not empty #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daidokoro @EldarAliiev please have a look on the PR |
daidokoro
reviewed
Sep 4, 2024
There was a problem hiding this comment.
@DimaGolomozy, thanks for the PR.
Can you add an explanation to the PR descriptions saying why this change is necessary. And how moving the SyncTime check to occur after the BuggerLenToSend Check addresses the issue.
Thanks.
updated the description |
daidokoro
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no need to do a time sync if the buffer of logs to send is empty.
only if there are logs to send, it should do a time sync.