Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/corl 2787 quick site search rebased #4344

Closed
wants to merge 23 commits into from

Conversation

marcushaddon
Copy link
Contributor

What does this PR do?

This PR makes it possible for moderators to search by site name while filtering comments by site in the moderation view.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None.

Does this PR introduce any new environment variables or feature flags?

No.

If any indexes were added, were they added to INDEXES.md?

No indexes were added or modified, but if you have not added a text index on sites as indicated in INDEXES.md, you will need to do that

(from INDEXES.md)

2021-12-17

db.sites.createIndex({ tenantID: 1, "$**": "text", createdAt: -1 });
  • This index creates a text search on sites so that when you use a text-filter base on site name, Mongo knows how to resolve your search query.

How do I test this PR?

  1. (Not required but helpful) create lots of sites
  2. As a user with moderation privileges navigate to the moderation queue
  3. Click on the Site Selector component in the upper left hand corner
  4. Observe that the dropdown opens as usual, and you can scroll through sites and it paginates as needed
  5. Observe that the button has turned into a text input
  6. Type the first few letters of a site name, wait one second
  7. Observe that the dropdown updates and is populated only by sites who's names begin with that prefix
  8. Select a site from the dropdown and observe that the menu closes, that site's name is displayed on the button, and comments are filtered to just comments from that site

Where any tests migrated to React Testing Library?

No.

How do we deploy this PR?

No special considerations needed.

@marcushaddon marcushaddon requested a review from kabeaty September 7, 2023 17:43
@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit f7098c7
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/64ff8bfe239069000809bcfb

@marcushaddon marcushaddon marked this pull request as draft September 7, 2023 17:45
display error in SiteSelectorContainer
@marcushaddon marcushaddon marked this pull request as ready for review September 11, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant