Merge pull request #56 from omzy83/ACF-50

maintain image order
corcel · Feb 9, 2018 · 981069b · 981069b
2 parents 32ecfc9 + 94d9d88
commit 981069b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/Field/Gallery.php b/src/Field/Gallery.php
@@ -30,7 +30,11 @@ public function process($field)
     {
         if ($ids = $this->fetchValue($field)) {
             $connection = $this->post->getConnectionName();
-            $attachments = Post::on($connection)->whereIn('ID', $ids)->get();
+
+            $ids_ordered = implode(',', $ids);
+
+            $attachments = Post::on($connection)->whereIn('ID', $ids)
+                ->orderByRaw("FIELD(ID, $ids_ordered)")->get();
 
             $metaDataValues = $this->fetchMultipleMetadataValues($attachments);
 

diff --git a/tests/ContentFieldsTest.php b/tests/ContentFieldsTest.php
@@ -97,8 +97,8 @@ public function testGalleryFieldValue()
             $this->assertTrue(strlen($image->url) > 0);
         }
 
-        // Testing the image in the 6th position
-        $image = $gallery->get()->get(6);
+        // Testing the image in the 0th position
+        $image = $gallery->get()->get(0);
         $this->assertEquals(1920, $image->width);
         $this->assertEquals(1080, $image->height);
     }