Skip to content

Commit

Permalink
drivers: dai: intel: ssp: fix LOG_ERR level / false positive
Browse files Browse the repository at this point in the history
There's no way this log level was intentional: this line is just the
title / prefix of a multi-line section with mostly LOG_INF statements.

Fixes commit 6423bc3 ("drivers: dai: intel: ssp: Improve logging
output") which was very large hence error-prone.

Fixes SOF bug thesofproject/sof#9026

(cherry picked from commit 1708122)

Original-Signed-off-by: Marc Herbert <marc.herbert@intel.com>
GitOrigin-RevId: 1708122
Change-Id: I8ca3d1b918a16d63e076ee14d784e64ac7c8bf99
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5449723
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Tested-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
  • Loading branch information
marc-hb authored and Chromeos LUCI committed Apr 12, 2024
1 parent 01ddd72 commit 46fc975
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/dai/intel/ssp/ssp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1764,7 +1764,7 @@ static void dai_ssp_set_reg_config(struct dai_intel_ssp *dp, const struct dai_co
ssrsa = SSRSA_GET(regs->ssrsa);
sscr1 = regs->ssc1 & ~(SSCR1_RSRE | SSCR1_TSRE);

LOG_ERR("SSP%d configuration:", dp->index);
LOG_INF("SSP%d configuration:", dp->index);
if (regs->sstsa & SSTSA_TXEN || regs->ssrsa & SSRSA_RXEN ||
regs->ssc1 & (SSCR1_RSRE | SSCR1_TSRE)) {
LOG_INF(" Ignoring %s%s%s%sfrom blob",
Expand Down

0 comments on commit 46fc975

Please sign in to comment.