Skip to content

Commit

Permalink
posix: remove unneeded option to link with posix subsys
Browse files Browse the repository at this point in the history
The CONFIG_APP_LINK_WITH_POSIX_SUBSYS option was originally
present so that internal POSIX implementation headers would be
on the include path.

There is no implicit need for any app or library to include
private POSIX headers. Instead, the standard POSIX API should
be used.

(cherry picked from commit e8b1784)

Original-Signed-off-by: Christopher Friedt <cfriedt@meta.com>
GitOrigin-RevId: e8b1784
Change-Id: Ife0226851093a58bd73bfa39b8798311f6a4b8f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5280060
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
Tested-by: Al Semjonovs <asemjonovs@google.com>
Commit-Queue: Al Semjonovs <asemjonovs@google.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
  • Loading branch information
cfriedt authored and Chromeos LUCI committed Feb 8, 2024
1 parent 0c77b0e commit 9efb7d3
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 15 deletions.
1 change: 0 additions & 1 deletion doc/services/portability/posix/kconfig/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ Configuration Options
This is a non-exhaustive list of specific :ref:`kconfig` options relating to Zephyr's
implementation of the POSIX API.

* :kconfig:option:`CONFIG_APP_LINK_WITH_POSIX_SUBSYS`
* :kconfig:option:`CONFIG_EVENTFD`
* :kconfig:option:`CONFIG_EVENTFD_MAX`
* :kconfig:option:`CONFIG_FDTABLE`
Expand Down
5 changes: 0 additions & 5 deletions lib/posix/options/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ zephyr_syscall_header(
posix_clock.h
)

zephyr_interface_library_named(posix_subsys)

if(CONFIG_POSIX_API)
zephyr_include_directories(${ZEPHYR_BASE}/include/zephyr/posix)
endif()
Expand Down Expand Up @@ -63,6 +61,3 @@ zephyr_library_include_directories(
${ZEPHYR_BASE}/kernel/include
${ARCH_DIR}/${ARCH}/include
)

zephyr_library_link_libraries(posix_subsys)
zephyr_library_property(ALLOW_EMPTY TRUE)
9 changes: 0 additions & 9 deletions lib/posix/options/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,6 @@ config POSIX_API
Enable mostly-standards-compliant implementations of
various POSIX (IEEE 1003.1) APIs.

# The name of this option is mandated by zephyr_interface_library_named
# cmake directive.
config APP_LINK_WITH_POSIX_SUBSYS
bool "Make POSIX headers available to application"
default y
depends on POSIX_API
help
Add POSIX subsystem header files to the 'app' include path.

if POSIX_CLOCK

config PTHREAD_IPC
Expand Down

0 comments on commit 9efb7d3

Please sign in to comment.