Skip to content

Commit

Permalink
drivers: gpio: imx rt11xx: fix wrong gpio pull disable mask
Browse files Browse the repository at this point in the history
A wrong bit mask (wrong: IOMUXC_SW_PAD_CTL_PAD_PUS_MASK = 0x8) was used.
That bit mask is for PUE/PUS-type gpio registers, but this is the
section for registers with alternative PULL (PDRV) type layout.
Right bit mask: IOMUXC_SW_PAD_CTL_PAD_PULL_MASK

(cherry picked from commit dcfc3e7)

Original-Fixes: #75390
Original-Signed-off-by: Nils Larsen <nils.larsen@posteo.de>
GitOrigin-RevId: dcfc3e7
Change-Id: Ic734626340fb5953c3f263d4225f50c487cbd58a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5682733
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Commit-Queue: Yuval Peress <peress@google.com>
Reviewed-by: Yuval Peress <peress@google.com>
Tested-by: Yuval Peress <peress@google.com>
  • Loading branch information
nelarsen authored and Chromeos LUCI committed Jul 8, 2024
1 parent f64c47e commit b3b0a8c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpio/gpio_mcux_igpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ static int mcux_igpio_configure(const struct device *dev,
}
} else {
/* Set pin to no pull */
reg |= IOMUXC_SW_PAD_CTL_PAD_PUS_MASK;
reg |= IOMUXC_SW_PAD_CTL_PAD_PULL_MASK;
}
/* PDRV/SNVS/LPSR reg have different ODE bits */
if (config->pin_muxes[cfg_idx].pdrv_mux) {
Expand Down

0 comments on commit b3b0a8c

Please sign in to comment.