Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus: add GetUnitFileState method #350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vaspahomov
Copy link
Contributor

No description provided.

dbus/methods.go Outdated Show resolved Hide resolved
dbus/methods.go Outdated Show resolved Hide resolved
dbus/methods.go Outdated Show resolved Hide resolved
@lucab
Copy link
Contributor

lucab commented Dec 15, 2020

@vaspahomov thanks for your patch. I've left a few comments in review, and it would be good to have a test for this too.

@vaspahomov vaspahomov force-pushed the feature/add-GetUnitFileState-method branch 2 times, most recently from 586b8f6 to 3ef922d Compare December 15, 2020 17:02
@vaspahomov vaspahomov force-pushed the feature/add-GetUnitFileState-method branch from 3ef922d to db69fcc Compare December 15, 2020 17:02
Copy link
Contributor

@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine but CI is failing. I think this is because you are trying to re-use a system service unit that may not exist on older OS version. It would be good to try with a dedicated unit instead.

func TestGetUnitFileState(t *testing.T) {
conn := setupConn(t)
defer conn.Close()
service := "systemd-udevd.service"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not exist in the testing environment. It would be good to set up a dedicated temporary service unit instead.

@GaikwadPratik
Copy link

@vaspahomov ,

Can you please resolve conflicts so @lucab can merge it?

@sigmonsays
Copy link

looking to call this method (GetUnitFileState) but it's just stale. Is there another way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants