Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split TryConcatAlong into different traits #892

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Split TryConcatAlong into different traits #892

merged 4 commits into from
Dec 4, 2023

Commits on Dec 4, 2023

  1. Added test (fails to compile)

    @swfsql
    swfsql committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    a633d53 View commit details
    Browse the repository at this point in the history

  2. Split TryConcatAlong into two traits 

    - Deprecated `TryConcatAlong` in favor of `TryConcatTensorAlong` or `TryConcatShapeAlong`.
- Created `concat_tensor_along/` and `concat_shape_along/`.
  - Copied relevant sections and files from `concat_along`, adjusting where necessary.
  - Moved `concat_along/` kernels to `concat_tensor_along/`.
- Adjusted the issue's integration test to the new trait, which runs successfully.
    @swfsql
    swfsql committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    2a31bdf View commit details
    Browse the repository at this point in the history

  3. Update dfdx-core/src/tensor_ops/concat_shape_along/mod.rs 

    Co-authored-by: Corey Lowman <clowman1993@gmail.com>
    @swfsql @coreylowman
    swfsql and coreylowman committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    7c88fb6 View commit details
    Browse the repository at this point in the history

  4. rm unneeded bound

    @swfsql
    swfsql committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    8655f2a View commit details
    Browse the repository at this point in the history