-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests with miri #899
Closed
Closed
Run tests with miri #899
Commits on Jan 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5c532ec - Browse repository at this point
Copy the full SHA 5c532ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb91f13 - Browse repository at this point
Copy the full SHA fb91f13View commit details
Commits on Feb 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 24a8593 - Browse repository at this point
Copy the full SHA 24a8593View commit details
Commits on Feb 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4e3f7c7 - Browse repository at this point
Copy the full SHA 4e3f7c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8bc54c - Browse repository at this point
Copy the full SHA a8bc54cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 557687c - Browse repository at this point
Copy the full SHA 557687cView commit details
Commits on Mar 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1175903 - Browse repository at this point
Copy the full SHA 1175903View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea879a1 - Browse repository at this point
Copy the full SHA ea879a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b15ab7 - Browse repository at this point
Copy the full SHA 6b15ab7View commit details -
Note that crossbeam is an indirect dependency and they are still to release a version that [passes](crossbeam-rs/crossbeam#996) on this miri check. So to temporarily get this out of the way, you can patch crossbeam on the workspace `dfdx/Cargo.toml`.
Configuration menu - View commit details
-
Copy full SHA for 44a41c0 - Browse repository at this point
Copy the full SHA 44a41c0View commit details -
miri pass nn::layers::add_into::tests::longer_network
Thread main finished before other threads were still active. The only thing related to threads were the gemm usage of rayon, and disabling rayon usage for matmul seems to be sufficient to fix this.
Configuration menu - View commit details
-
Copy full SHA for 4251a77 - Browse repository at this point
Copy the full SHA 4251a77View commit details -
Free cache memory on
TensorCache
drop- Moved the impl of `Cache::try_empty_cache()` to `TensorCache::clear()`. - This can be invoked both by `Cache::try_empty_cache()` and by `drop(TensorCache)`. - Moved the device cache ptr deallocation to `BytesPtr`, `CudaBytesPtr` (newtype over `CUdeviceptr`) and `Buffer`. - This is abstracted by the `CachePtr` trait. - Can be called by `TensorCache::clear()`. - This method may require some "extra" device information, such as in the cuda case. That information is held by `TensorCache`.
Configuration menu - View commit details
-
Copy full SHA for 8f43ce5 - Browse repository at this point
Copy the full SHA 8f43ce5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.