Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with miri #899

Closed
wants to merge 12 commits into from
Closed

Run tests with miri #899

wants to merge 12 commits into from

Commits on Jan 26, 2024

  1. Configuration menu
    Copy the full SHA
    5c532ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb91f13 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge pull request #1 from rainiwu/remove-ftz

    Remove ftz
    swfsql authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    24a8593 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. avoid conv1d bound for cudnn

    swfsql committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4e3f7c7 View commit details
    Browse the repository at this point in the history
  2. bump gemm

    swfsql committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    a8bc54c View commit details
    Browse the repository at this point in the history
  3. clippy fix

    swfsql committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    557687c View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Merge pull request #2 from swfsql/avoid-ci-errors

    Avoid ci errors
    swfsql authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    1175903 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea879a1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6b15ab7 View commit details
    Browse the repository at this point in the history
  4. patch crossbeam

    Note that crossbeam is an indirect dependency and they are still to release a version that [passes](crossbeam-rs/crossbeam#996) on this miri check.
    
    So to temporarily get this out of the way, you can patch crossbeam on the workspace `dfdx/Cargo.toml`.
    swfsql committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    44a41c0 View commit details
    Browse the repository at this point in the history
  5. miri pass nn::layers::add_into::tests::longer_network

    Thread main finished before other threads were still active. The only
    thing related to threads were the gemm usage of rayon, and disabling
    rayon usage for matmul seems to be sufficient to fix this.
    swfsql committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    4251a77 View commit details
    Browse the repository at this point in the history
  6. Free cache memory on TensorCache drop

    - Moved the impl of `Cache::try_empty_cache()` to `TensorCache::clear()`.
      - This can be invoked both by `Cache::try_empty_cache()` and by `drop(TensorCache)`.
    - Moved the device cache ptr deallocation to `BytesPtr`, `CudaBytesPtr` (newtype over `CUdeviceptr`) and `Buffer`.
      - This is abstracted by the `CachePtr` trait.
      - Can be called by `TensorCache::clear()`.
      - This method may require some "extra" device information, such as in the cuda case. That information is held by `TensorCache`.
    swfsql committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    8f43ce5 View commit details
    Browse the repository at this point in the history