Created Modal in ProfileForm.tsx, added profile deletion from firebas… #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e functionality to deleteUser endpoint in views.tsx and created a BigRed Variety for buttons in Button.tsx
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akinfelami
requested changes
Apr 17, 2024
| }, | ||
| retry: false, | ||
| onSuccess: () => { | ||
| console.log("DELETED"); |
| } = useForm<DeleteAccountFormValues>(); | ||
|
|
||
| //changeUserStatus handles deleting user from prisma and firebase | ||
| const { mutateAsync: changeUserStatus, error: changeUserStatusError } = |
There was a problem hiding this comment.
You should use appropriate naming patterns. I don't think changeUserStatus is the way
Comment on lines
100
to
101
| await changeUserStatus(); | ||
| await handleSignOut(); |
There was a problem hiding this comment.
Wrap this in a try catch, it is possible that it fails and the user will need some feedback that the action failed
Comment on lines
265
to
275
| // const { mutateAsync: changeUserStatus } = useMutation({ | ||
| // mutationFn: async () => { | ||
| // const { data } = await api.delete(`/users/${userid}`); | ||
| // return data; | ||
| // }, | ||
| // retry: false, | ||
| // onSuccess: () => { | ||
| // console.log("DELETED"); | ||
| // } | ||
| // }); | ||
|
|
akinfelami
approved these changes
Apr 24, 2024
akinfelami
approved these changes
May 6, 2024
jasozh
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H1 Account-Deletion-FullStack
Summary
Closes #207
Testing
Notes