Email notifications setting using checkbox #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d added updatePreferences in profileForm
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akinfelami
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Great work guys!
I have some comments for the review:
- Yes, you tested that you did not receive an email after unchecking the box, but can you confirm that it works the other way around ? so when the box is checked you receive an email?
- I'm curious how you tested this because I am unable to without having to change passwords. Did you encounter this? If so, did the emailNotifications state persist on refresh?
backend/src/users/controllers.ts
Outdated
| @@ -507,14 +508,16 @@ const getUserPreferences = async (userId: string) => { | |||
| */ | |||
| const editPreferences = async ( | |||
| userId: string, | |||
| preferences: UserPreferences | |||
| preferences: UserPreferences, | |||
| // emailNotifications: boolean | |||
backend/src/users/controllers.ts
Outdated
| @@ -492,6 +492,7 @@ const getUserPreferences = async (userId: string) => { | |||
| return prisma.user.findUnique({ | |||
| where: { | |||
| id: userId, | |||
| // sendEmailNotification: emailNotifications, | |||
backend/src/users/controllers.ts
Outdated
| ) => { | ||
| return prisma.user.update({ | ||
| where: { id: userId }, | ||
| data: { | ||
| preferences: { | ||
| update: { | ||
| ...preferences, | ||
| // sendEmailNotification: emailNotifications, |
| @@ -89,7 +91,7 @@ const ProfileForm = ({ userDetails }: ProfileFormProps) => { | |||
| oldPassword: "", | |||
| newPassword: "", | |||
| confirmNewPassword: "", | |||
| emailNotifications: false, | |||
| emailNotifications: true, | |||
There was a problem hiding this comment.
why is the default case change to true?
| @@ -98,7 +100,8 @@ const ProfileForm = ({ userDetails }: ProfileFormProps) => { | |||
| // TODO: Implement this | |||
| const [checked, setChecked] = useState(false); | |||
| const handleCheckbox = () => { | |||
| setChecked((checked) => !checked); | |||
| setChecked ((checked) => !checked); | |||
| setEmailNotifications((prev) => !prev); | |||
There was a problem hiding this comment.
hmm I think you already have the information you need in the checked state
akinfelami
approved these changes
May 6, 2024
jasozh
reviewed
Jun 2, 2024
There was a problem hiding this comment.
BUG: Checkbox needs to be clicked then unclicked. Leaving it empty does not change the state of the email preferences.
===
FIXED: Checkbox does not show the actual state on page load, always remains unchecked.
FIXED: Profile uses /users instead of /users/search
jasozh
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #237
Added a new function in ProfileForm.tsx called updatePreferencesInDB which takes the changed data from the checkbox and edits that users preferences. We then added if statements in all the sendEmail function calls within events/controllers.ts and users/controllers.ts to check if the user's email notifications are on or off. It only sends the email if the user's notifications are on.
Testing
I used my log in and selected that I did not want email notifications and then I registered for an event. I did not receive an email so it appears to be working.