Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nifti): update nifti-reader-js to 0.6.8 #1286

Merged
merged 5 commits into from
May 28, 2024

Conversation

yanqzsu
Copy link
Contributor

@yanqzsu yanqzsu commented May 28, 2024

Context

Update nifti-reader-js from 0.6.6 to 0.6.8 because it supports to read files with corrupt extension.
Test data is here.
https://github.com/neurolabusc/niivue-images/blob/main/chris_MRA.nii.gz

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented May 28, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 4a48392
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/66560fdce664ae0008149216
😎 Deploy Preview https://deploy-preview-1286--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi
Copy link
Member

sedghi commented May 28, 2024

Thank you so much for pushing on the nifti side, i will review this and merge your other PR today

@sedghi sedghi merged commit e3704cd into cornerstonejs:main May 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants