-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency reduction #262
Draft
k1o0
wants to merge
603
commits into
dev
Choose a base branch
from
dependencyReduction
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dependency reduction #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix for registering hw info
bugfix for registering hw.info
…als' (dev) submodules
Added coverage badge
…pull request changes Test Panel as Classes modeled off SignalsExp & MControl variable name changes to exp.SignalsExp added 'cprintf.m' updated signals submodule updated signals submodule updates submodule signals updates signals submodule (TestPanelClasses branch) updated submodule signals (TestPanelClasses branch) MControl and mc commits to match dev branch alyx-related commits to match dev branch updated submodule signals (TestPanelClasses branch) updated submodule signals (TestPanelClasses branch) updated signals submodule (to 'TestPanelClasses' branch) and alyx-matlab(to 'dev' branch) and improved 'namedArg' updated signals submodule ('TestPanelClasses') after rebasing that branch in that submodule typo fix in 'hw.devices' made changes for Miles updated signals (TestPanelClasses) submodule Rebased 'TestPanelClasses' onto 'dev' at diverge point after pull request changes Rebased 'TestPanelClasses' onto 'dev' at diverge point Test Panel as Classes modeled off SignalsExp & MControl variable name changes to exp.SignalsExp added 'cprintf.m' updated signals submodule updated signals submodule updates submodule signals updates signals submodule (TestPanelClasses branch) updated submodule signals (TestPanelClasses branch) MControl and mc commits to match dev branch alyx-related commits to match dev branch updated submodule signals (TestPanelClasses branch) updated submodule signals (TestPanelClasses branch) updated signals submodule (to 'TestPanelClasses' branch) and alyx-matlab(to 'dev' branch) and improved 'namedArg' updated signals submodule ('TestPanelClasses') after rebasing that branch in that submodule typo fix in 'hw.devices' made changes for Miles updated signals (TestPanelClasses) submodule updated signals (TestPannelClasses) submodule after incorporating pull request changes undid variable name changes for Miles
… test for repelems
* use the correct channels for gamma cal as specified * label output plots correctly
* Started expServer tests * Added more tests; bug fix for older versions * Removed validation functions for old MATLAB versions; added documentation * More coverage, documentation * Draws text to screen during calibration #128 * Fix for #4 * Added structAssign test; rewardId tests * Typo fix in structAssign_test * Finished tests for expServer * #156 * Returned listener delete to cleanup * Stricter tolerance in AlyxPanel_test; bug fix for rounding negative numbers * Update alyx-matlab submodule * Minor changes to documentation * Update CHANGELOG.md * Typo fix; 'off' -> false for safety
updated error message bug fix checking signalGen class made 'checkRewardValveCalibration' more general - have to test optimized logical indexing updated before creating mock objects for tests added todo for creating appropriate tests added test file
This reverts commit 3d29c7e.
* #219 fix for scale cleanup on error * Update to CHANGELOG * Support for remote error IDs * Added test for StimulusControl and fixed err id in expServer test
* Started expServer tests * Added more tests; bug fix for older versions * Removed validation functions for old MATLAB versions; added documentation * More coverage, documentation * Draws text to screen during calibration #128 * Fix for #4 * Added structAssign test; rewardId tests * Typo fix in structAssign_test * Finished tests for expServer * #156 * Returned listener delete to cleanup * Stricter tolerance in AlyxPanel_test; bug fix for rounding negative numbers * Update alyx-matlab submodule * Minor changes to documentation * Update CHANGELOG.md * Added tests for tl.bindMpepServer and pnet spy * Fixture path fix * Moved audioDevices default to devices mock * Assertion added #204
* single-character change to README.md to test if I still have permission to push to dev (hopefully I don't) * modified paths_template to be consistent with current cortexlab server settings * Changes to server name vars in paths template
* Returned access restriction; started docs; Hiding info fields and comments box; cleaner subclassing * Rethrow Signals update mismatch as warning, #72 * SqueakExpPanel -> SignalsExpPanel * Removed code for very specific experiment that is no longer used * Completed using_ExpPanel docs * Formatting docs * Issue #79 * Cleaned up UpdatesFilter * documentation; changed plot colours
* Tiny changes to appease MATLAB * Started installation section * Added matlabdomain extension * Added infomation for remote location in reposPath * Started a setup page * Added parameters walkthrough * HOTFIX changed Alyx Panel login timer to 90 mins * 2.3 <- 2.2.1 (#198) * updated signals submodule * updated signals submodule (eb71b1f) * Added test for ensureCell * Fix'd typo in ensureCell_test * Future-proofing runall to ignore tests with specific hardware requirements * Added tests for nop, iff and emptyElems * Added tests for cellsprintf and num2cellstr; bug fix in num2cellstr * Submodule update * mapToCell test * Removed complete todos * Added test for dat.expExists * Restore changes made in commit 247060a * Expanded test for dispWaterReq * assert -> verifyMatches * Added catStructs test * Added tabulateArgs test * superSave test added * added an informative error message in the case that dat.paths is missing * Attempting to construct a branch that doesn't differ from dev in its submodules * Revert "Attempting to construct a branch that doesn't differ from dev in its submodules" Reverting a commit that should have been to dev_kevin, not to dev * Revert "added an informative error message in the case that dat.paths is missing" Reverting a commit that should have been to dev_kevin, not to dev This reverts commit a492bd2. * Added file package test * Added test for pick * Added test for namedArg * Added varName test * Added back tolerance change * Dev kevin (#192) * added an informative error message when dat.paths is not present * added an identifier to the error message * Added warnings and errors to deal with the case that hardware.mat is not found * fixed identifier * Changed error identifiers following Miles' suggestion of module:package:function:error * added more info to error for empty rig * added more info to no dat.paths error * Bug fix in namedArg test * Removed old function -> now a method of Alyx * Started +fun package test; added fileFunction test * No longer using 'which' to assert function existence * Bug fixes for tests * Bug fix for wiringInfo method * Added KeyedSeq test * Added docs for apply and applyForce * Added loadVar test * Issue #168 * Added mergeStructs test * Added performance tests; reorganized tests; updated changelog * Added parameters walkthrough * Added timeline walkthrough; bug fix for wiringInfo in Timeline * added informative error messages to calibration code * Added documentation for setting up Window; documentation for Window class; Minor bug fixes * Added a few examples to hardware docs * Added Viewing model walkthrough and expanded FAQ * Updated changelog * Updates to docs * Added test for +hw/calibrate.m * deleted exp.construct * Added documentation for calibration test * Updated docs; added services guide * Updates docs * Fix for Communicator WTF mode; increased test coverage for iff * Update to changelog and signals * HOTFIX changed Alyx Panel login timer to 90 mins * Removed readthedocs, updated submodules * Update Shields * HOTFIX: Correct location of docs in README; Stronger wording in install instructions * Added issue templates (#179) * Added troubleshooting docs and error id list * Using signals error handling branch; added troubleshooting doc * Re-factoring SignalsExp for test subclassing * Started expServer tests * Added more tests; bug fix for older versions * Removed validation functions for old MATLAB versions; added documentation * More coverage, documentation * Draws text to screen during calibration #128 * Fix for #4 * Added structAssign test; rewardId tests * Typo fix in structAssign_test * Finished tests for expServer * #156 * Returned listener delete to cleanup * Stricter tolerance in AlyxPanel_test; bug fix for rounding negative numbers * Update alyx-matlab submodule * Minor changes to documentation * Update CHANGELOG.md * Added tests for tl.bindMpepServer and pnet spy * Fixture path fix * Moved audioDevices default to devices mock * WIP * #100 #202 * Updated tests with share fixtures; added pause/resume to SignalsExp; added further tests for SignalsExp; updated tests README; SessionURL fetched from database when necessary * Added better update of keyboard input signal * Potential fix for #213 * Updates to submodules * Update to alyx-matlab * Context menu for hiding event updates in ExpPenel * trialCondition index can be reset with signal * Improvements to test UI * Documentation * README for +eui package (#156) * WIP * Removed warning from updateLogEntry when Alyx deactivated #202 * Added hide option for ExpPanel; ExpPanel guide in docs * Added utils; started docs * #218 * Support for ids in errOnFail * Removed old commented-out code * Scale port closed on errors * Added brief PTB install instructions (#228) * cleanup * Documentation; #229 * More flags for addRigboxPaths * started updating README after Anwar's comments * updated some instructions in README * Revert "started updating README after Anwar's comments" This reverts commit 9f5a456. * Updated documentation * Removed PTBDebug call and added example to docstring * Update to CHANGELOG and signals * #205 - refactored * Update to tests * Warning supression in tests * CHANGELOG Co-authored-by: Jai Bhagat <j.bhagat@ucl.ac.uk>
* Fix for eui.ExpPanel/live input parse error and tests added * Updated CHANGELOG and tests Contents file
* Added troubleshooting to index * Fixed external links in index * Updated index version number * Documented stimulusControllers and typo fix in MockDialog * Documented tabulateArgs * README and CONTRIBUTING * Updated badges * Ignore todos in html
* tests and documentation for *paramProfile functions; repos created when none exist * CHANGELOG
* Added label format option to SignalsExpPanel * CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of stats toolbox dependencies. This needs thoroughly testing before merging, especially the hw.PulseSwitcher changes.