fix: ignore version conflicts in destroy calls #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a small reproducer. Make the destroy code treat not found version as successful deletion. Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
Unix4ever
force-pushed
the
fix-delete-conflicts
branch
from
c678bfb to
a316525
Compare
Unix4ever
changed the title
smira
approved these changes
Jul 25, 2024
|
|
||
| var eg errgroup.Group | ||
|
|
||
| err := s.Create(ctx, res) |
There was a problem hiding this comment.
I would probably move this to COSI conformance, as it should pass for all state implementations.
There was a problem hiding this comment.
I can add it there too. And keep it here
There was a problem hiding this comment.
This repo should run all conformance from COSI anyways.
|
/m |
Unix4ever
added a commit
to Unix4ever/omni
that referenced
this pull request
Jul 25, 2024
See: cosi-project/state-etcd#158 Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a small reproducer.
Make the destroy code treat not found version as successful deletion.