-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove baseapp from x/accounts
#23355
Merged
Merged
+205
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core/testing is getting great 🚀
12 tasks
technicallyty
approved these changes
Jan 16, 2025
aljo242
added
the
backport/v0.52.x
PR scheduled for inclusion in the v0.52's next stable release
label
Jan 16, 2025
github-actions
bot
removed
C:x/staking
C:x/slashing
C:x/distribution
distribution module related
C:x/mint
C:Simulations
C:x/evidence
C:x/feegrant
C:x/nft
C:x/consensus
C:x/circuit
C:server/v2
Issues related to server/v2
C:x/protocolpool
C:x/epochs
C:x/accounts/lockup
C:x/accounts/multisig
C:server/v2 cometbft
C:x/accounts/base
labels
Jan 16, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com> (cherry picked from commit 952db2b) # Conflicts: # client/v2/go.mod # core/testing/go.mod # core/testing/go.sum # core/testing/queryclient/queryclient.go # simapp/v2/go.mod # tests/go.mod # tests/integration/v2/accounts/fixture_test.go # tests/integration/v2/accounts/lockup/utils.go # tests/integration/v2/accounts/multisig/test_suite.go # tests/integration/v2/auth/app_test.go # tests/integration/v2/distribution/fixture_test.go # tests/integration/v2/gov/common_test.go # tests/integration/v2/gov/keeper/fixture_test.go # tests/integration/v2/services.go # x/accounts/go.mod # x/authz/go.mod # x/bank/keeper/keeper_test.go # x/gov/go.mod # x/group/go.mod
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/v0.52.x
PR scheduled for inclusion in the v0.52's next stable release
C:CLI
C:core/testing
C:x/accounts
C:x/authz
C:x/bank
C:x/gov
C:x/group
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
part of #22903
integration
test MsgRouter logic tocoretesting
so that it can be used as a common function in keeper and integration level tests.baseapp
import entirely in `x/accountsAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Dependency Updates
google.golang.org/grpc
to versionv1.69.4
across multiple modulescosmossdk.io/core/testing
replacement directives in variousgo.mod
filesTesting Infrastructure
msgrouter
package for message routing in integration testsintegration.RouterService()
withmsgrouter.RouterService()
across test suitesModule Refactoring
go.mod
filescore/testing
module to1.23.1
Code Cleanup