Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove baseapp from x/accounts #23355

Merged
merged 56 commits into from
Jan 16, 2025
Merged

Conversation

aljo242
Copy link
Collaborator

@aljo242 aljo242 commented Jan 13, 2025

Description

part of #22903

  • Moves integration test MsgRouter logic to coretesting so that it can be used as a common function in keeper and integration level tests.
  • Remove baseapp import entirely in `x/accounts

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Dependency Updates

    • Updated google.golang.org/grpc to version v1.69.4 across multiple modules
    • Added cosmossdk.io/core/testing replacement directives in various go.mod files
  • Testing Infrastructure

    • Introduced new msgrouter package for message routing in integration tests
    • Replaced integration.RouterService() with msgrouter.RouterService() across test suites
    • Updated query client and router service implementations
  • Module Refactoring

    • Simplified codec and query handling in test environments
    • Restructured module replacements in go.mod files
    • Updated Go version in core/testing module to 1.23.1
  • Code Cleanup

    • Removed deprecated router and event service implementations
    • Simplified message and query handler registrations

@aljo242 aljo242 requested a review from technicallyty January 15, 2025 21:22
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/testing is getting great 🚀

@julienrbrt julienrbrt mentioned this pull request Jan 16, 2025
12 tasks
@aljo242 aljo242 added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Jan 16, 2025
@aljo242 aljo242 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 952db2b Jan 16, 2025
84 of 85 checks passed
@aljo242 aljo242 deleted the chore/remove-baseapp-accounts branch January 16, 2025 18:59
mergify bot pushed a commit that referenced this pull request Jan 16, 2025
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
(cherry picked from commit 952db2b)

# Conflicts:
#	client/v2/go.mod
#	core/testing/go.mod
#	core/testing/go.sum
#	core/testing/queryclient/queryclient.go
#	simapp/v2/go.mod
#	tests/go.mod
#	tests/integration/v2/accounts/fixture_test.go
#	tests/integration/v2/accounts/lockup/utils.go
#	tests/integration/v2/accounts/multisig/test_suite.go
#	tests/integration/v2/auth/app_test.go
#	tests/integration/v2/distribution/fixture_test.go
#	tests/integration/v2/gov/common_test.go
#	tests/integration/v2/gov/keeper/fixture_test.go
#	tests/integration/v2/services.go
#	x/accounts/go.mod
#	x/authz/go.mod
#	x/bank/keeper/keeper_test.go
#	x/gov/go.mod
#	x/group/go.mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants