Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Dockerfile.gaia not pulling the latest version #1397

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

p-offtermatt
Copy link
Contributor

Description

Closes: N/A

Dockerfile.gaia is not pulling the latest version, contrary to what it claims in the comment.
The current line sorts by lexicographic order, i.e.

 $ git tag
stargate-6
stargate-6-a
stargate-6-b
v0.0.0
v0.0.1-rc0
v1.0.0
v1.0.0-rc1
v1.0.0-rc2
v1.0.0-rc3
v10.0.0
v10.0.0-rc0
v10.0.1
v10.0.2
v11.0.0
v11.0.0-rc0
v12.0.0
v12.0.0-rc0
v13.0.0
v13.0.0-rc0
v13.0.1
v2.0.0
v2.0.0-rc1
v2.0.1
v2.0.10
v2.0.11
v2.0.12
v2.0.13
v2.0.14
v2.0.15
v2.0.2
v2.0.3
v2.0.4
v2.0.5
v2.0.6
v2.0.7
v2.0.8
v2.0.9
v3.0.0
v3.0.1
v4.0.0
v4.0.1
v4.0.2
v4.0.3
v4.0.4
v4.0.5
v4.0.6
v4.1.0
v4.1.1
v4.1.2
v4.2.0
v4.2.1
v5.0.0
v5.0.1
v5.0.2
v5.0.3
v5.0.4
v5.0.5
v5.0.6
v5.0.7
v5.0.8
v6.0.0
v6.0.0-rc1
v6.0.0-rc2
v6.0.0-rc3
v6.0.1
v6.0.2
v6.0.3
v6.0.4
v7.0.0
v7.0.0-rc0
v7.0.1
v7.0.2
v7.0.3
v7.1.0
v7.1.1
v8.0.0
v8.0.0-rc
v8.0.0-rc1
v8.0.0-rc2
v8.0.0-rc3
v8.0.0-rc4
v8.0.0-rc5
v8.0.1
v9.0.0
v9.0.0-rc0
v9.0.0-rc1
v9.0.0-rc2
v9.0.0-rc3
v9.0.0-rc4
v9.0.0-rc5
v9.0.0-rc6
v9.0.0-rc7
v9.0.1
v9.0.1-rc0
v9.0.2
v9.0.2-rc0
v9.0.3
v9.0.3-rc0
v9.1.0
v9.1.1

Thus, this tries to build v9.1.1.

The adjusted sorting actually sorts correctly (though it is reversed in order now, which is why we take head instead of tail).

% git tag | sort -Vr           
v13.0.1
v13.0.0-rc0
v13.0.0
v12.0.0-rc0
v12.0.0
v11.0.0-rc0
v11.0.0
v10.0.2
v10.0.1
v10.0.0-rc0
v10.0.0
v9.1.1
v9.1.0
v9.0.3-rc0
v9.0.3
v9.0.2-rc0
v9.0.2
v9.0.1-rc0
v9.0.1
v9.0.0-rc7
v9.0.0-rc6
v9.0.0-rc5
v9.0.0-rc4
v9.0.0-rc3
v9.0.0-rc2
v9.0.0-rc1
v9.0.0-rc0
v9.0.0
v8.0.1
v8.0.0-rc5
v8.0.0-rc4
v8.0.0-rc3
v8.0.0-rc2
v8.0.0-rc1
v8.0.0-rc
v8.0.0
v7.1.1
v7.1.0
v7.0.3
v7.0.2
v7.0.1
v7.0.0-rc0
v7.0.0
v6.0.4
v6.0.3
v6.0.2
v6.0.1
v6.0.0-rc3
v6.0.0-rc2
v6.0.0-rc1
v6.0.0
v5.0.8
v5.0.7
v5.0.6
v5.0.5
v5.0.4
v5.0.3
v5.0.2
v5.0.1
v5.0.0
v4.2.1
v4.2.0
v4.1.2
v4.1.1
v4.1.0
v4.0.6
v4.0.5
v4.0.4
v4.0.3
v4.0.2
v4.0.1
v4.0.0
v3.0.1
v3.0.0
v2.0.15
v2.0.14
v2.0.13
v2.0.12
v2.0.11
v2.0.10
v2.0.9
v2.0.8
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v2.0.0-rc1
v2.0.0
v1.0.0-rc3
v1.0.0-rc2
v1.0.0-rc1
v1.0.0
v0.0.1-rc0
v0.0.0
stargate-6-b
stargate-6-a
stargate-6
stargate-4
stargate-3
stargate-2
stargate-1a
stargate-1
list
goz-phase-3
goz-phase-2
goz-phase-1
cosmoshub-test-stargate-e
cosmoshub-test-stargate-2
cosmoshub-test-stargate

Neither the new nor the old version handle the random tags flying around very well,
so I think the change shouldn't make anything worse in that (and we avoid problems with this by keeping our tags neat in the future).

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@p-offtermatt p-offtermatt marked this pull request as ready for review November 7, 2023 08:37
@p-offtermatt p-offtermatt requested a review from a team as a code owner November 7, 2023 08:37
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@p-offtermatt p-offtermatt changed the title fix: Fix Dockerfile.gaia: use latest tag fix: Fix Dockerfile.gaia Nov 7, 2023
@p-offtermatt p-offtermatt changed the title fix: Fix Dockerfile.gaia fix: Fix Dockerfile.gaia not pulling the latest version Nov 8, 2023
@mpoke mpoke merged commit b5227c8 into main Nov 9, 2023
14 checks passed
@mpoke mpoke deleted the ph/fix-gaia-dockerfile branch November 9, 2023 17:33
MSalopek pushed a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants