-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Introduce Partial Set Security #1809
Merged
Merged
Changes from all commits
Commits
Show all changes
116 commits
Select commit
Hold shift + click to select a range
2b5ff82
cleanup ./changelog entries
mpoke 9991d43
docs: changelog and release notes for v4.0.0 (#1564)
mpoke 04a669c
fix!: Validation of SlashAcks fails due to marshaling to Bech32 (bac…
mergify[bot] e7e586e
docs: update changelog for v4.0.0 (#1578)
mpoke 5aa1c50
docs: prepare for v4.0.0 (#1581)
mpoke 1f1d3bd
feat!: enable Opt In and Top N chains through gov proposals (#1615)
insumity 6693dd3
feat!: introduce MsgOptIn and MsgOptOut (#1620)
insumity 7ab3557
test: MBT: Add partial set security to model (feature branch version)…
p-offtermatt 4bf5917
test: Ports key assignment to the driver on the PSS feature branch (#…
p-offtermatt 7b0afcd
feat!: automatically opt in validators that vote Yes on consumer addi…
insumity 64f5651
test: Add driver for PSS (#1636)
p-offtermatt ab7236d
feat!: add PSS reward distribution spike (#1632)
sainoe 71315ef
feat! use protos to serialize opted-in validators (#1659)
sainoe e8cd100
feat!: PSS enable per-consumer chain commission (#1657)
sainoe 93647fe
test: update integration test suite for PSS (#1687)
sainoe d14cbac
docs: changelog and release notes for v4.0.0 (#1564)
mpoke 5ccd900
fix!: Validation of SlashAcks fails due to marshaling to Bech32 (bac…
mergify[bot] f62d17c
docs: update changelog for v4.0.0 (#1578)
mpoke a7b93a7
feat!: enable Opt In and Top N chains through gov proposals (#1615)
insumity 6e2618b
feat!: introduce MsgOptIn and MsgOptOut (#1620)
insumity ee65399
test: MBT: Add partial set security to model (feature branch version)…
p-offtermatt 7497fc0
feat!: add PSS reward distribution spike (#1632)
sainoe c689111
feat!: PSS enable per-consumer chain commission (#1657)
sainoe 5d54702
fix nits in MBT model after merging #1676 from main
sainoe 24942e2
Fix merging ccv model
p-offtermatt b30b6be
Remove conflict markers
p-offtermatt 18e7f25
Remove more conflict markers
p-offtermatt 581a983
EndProviderEpoch takes ConsumerAdditionMsg
p-offtermatt 955528c
Fix using consumer addition msgs instead of chain names in boundeddri…
p-offtermatt ef56ccf
lint
sainoe a4ecead
Merge branch 'main' into sainoe/pss-merge
sainoe 3947a69
chore: rebase PSS branch with main (#1689)
sainoe 31a9ee3
feat!: complete the PSS reward distribution (#1709)
sainoe 3ca33ec
feat!: Add slashing logic for PSS (#1710)
sainoe 79abc14
ci: do not scan the tests for security issues (#1717)
insumity b251141
feat!: compute partial sets (#1702)
insumity 72f5f66
feat!: update PSS cli (#1708)
sainoe 8ed60ee
Rename and add comission rate command to commands
p-offtermatt a6989bf
feat!: only perform consumer additions for non-empty chains (#1730)
insumity bfe10df
feat: Add queries for PSS and consumer commission rate (#1733)
sainoe 26f3c82
fix!: Fix opt-in assignment (#1732)
p-offtermatt 67ca8e8
fix silly bug in PSS opted-in val query
sainoe e4690f2
fix logging in ibc_module.go
mpoke bff07fe
test: add partial-set-security E2E tests (#1737)
insumity d0f7a42
Nit changes based on Simons comments. To be pushed directly because E…
insumity 67091f8
fix!: return a SlashAck even if the validator is not a consumer valid…
insumity f9344e2
test: Expand PSS e2e test to include slashing (#1752)
p-offtermatt 795c9fd
fix!: update unbonding pausing for PSS (#1728)
sainoe 237dbb8
Merge branch 'main' into feat/partial-set-security
p-offtermatt d4419ca
Get back 3.2.0 and 3.3.0 changelog from main
p-offtermatt 45b77bc
Port epilogue from main
p-offtermatt 6b86836
Fix proto conflict
p-offtermatt 6ccb8ed
generate proto files
sainoe 4278780
Port RELEASE_NOTES
p-offtermatt 05148d7
Merge branch 'feat/partial-set-security' of https://github.com/cosmos…
p-offtermatt 7c35183
Fix merge for tests
p-offtermatt 411ca4d
Merge declaration and assignment
p-offtermatt 62edffe
Clean up model files
p-offtermatt 4e51c65
Add pss tests to MBT readme
p-offtermatt f212598
Restore MsgSubmitConsumerDoubleVoting handler
p-offtermatt 49d7e84
Remove local driver files
p-offtermatt 7f0891a
Remove Quint guidelines
p-offtermatt 2262a8b
Add optin/optout to MBT readme
p-offtermatt d53637d
Fix types in model
p-offtermatt 545c8d9
Fix model
p-offtermatt c960ed2
Add migration
p-offtermatt 769d52f
Ensure SlashAcks are sent even when the valset does not change
p-offtermatt e0e6524
adding changelog entry
mpoke 0963f41
Empty DowntimeSlachAcks on EndBlock
p-offtermatt a143044
Merge branch 'feat/partial-set-security' of https://github.com/cosmos…
p-offtermatt cdf7790
Remove logs
p-offtermatt 3571b76
Change condition for sending slash acks
p-offtermatt 19b7672
Revert model changes
p-offtermatt 9270767
Start fixing PSS issues in model
p-offtermatt 925ae40
Add expected errors to opt out action
p-offtermatt df51697
Revert PSS quint model changes
p-offtermatt 0a7a85b
Add parameter to ComputeNextEpochConsumerValSet
p-offtermatt 35a3414
Set top N param in setup
p-offtermatt 1f382c7
Fix: do not try key assignment if there is no nonjailed validator
p-offtermatt c0eafd0
Do not assign keys for jailed validators
p-offtermatt e34f5bb
Only jail validators with non-zero-power
p-offtermatt fc09cf3
Add unit test
p-offtermatt efcc909
Add unit test for unset case
p-offtermatt e3d676d
Panic on not being able to unmarshal
p-offtermatt 6971ed3
Move packet handling into ack.Success block
p-offtermatt e5072b5
Format
p-offtermatt b133220
Remove unnecessary comment
p-offtermatt c075ffa
Add parens for clarity
p-offtermatt e92a58f
Format and fix typo
p-offtermatt 1105c4b
Move OptIn/OptOut events to provider events
p-offtermatt 9e91c2a
Remove unused function
p-offtermatt 90c54c6
Improve comments for keys
p-offtermatt 0d4e7f3
Improve comments for key getter functions
p-offtermatt 7b9842f
Remove order change for existing keys
p-offtermatt d7ac7e7
Re-add nolint instruction
p-offtermatt 1e1e285
nit comment fix
insumity fb4fc55
Move ConsumerAllocationTests to correct folder
p-offtermatt 92fc432
nit comment fix
insumity d2a904d
fix!: handle consumer commission marshalling errors gracefully (#1836)
sainoe d2cedd0
fix: update queries REST path for PSS (#1839)
sainoe eab6b8b
Clarify that GetProposedConsumerChain is test-only
p-offtermatt 8b7b938
fix: Fix has-to-validate query (#1823)
p-offtermatt aef34a1
Merge branch 'feat/partial-set-security' of https://github.com/cosmos…
p-offtermatt 31a7aa3
fix!: fix slashing in PSS (#1838)
sainoe 922faa8
Update x/ccv/provider/types/msg.go
p-offtermatt daedac9
Remove BlockValidatorUpdate from expected staking keeper
p-offtermatt 97d62bc
added an error response value to ComputeMinPowerToOptIn
insumity cac367e
delete additional state when we stop a chain
insumity e8eaa4f
Assign keys and change voting power only for unjailed nodes with >0 p…
p-offtermatt c106389
Merge branch 'feat/partial-set-security' of https://github.com/cosmos…
p-offtermatt b3d47ed
fix: Validate consumer commission rate against minimal rate (#1834)
p-offtermatt b131852
feat!: introduce power shaping (#1830)
insumity 74479ea
Update v4 to v5 in package version
p-offtermatt 967737b
Bump consensus version
p-offtermatt 8a14a78
Add migration in correct folder
p-offtermatt 940d60a
Update version from v4 to v5 in migration
p-offtermatt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
2 changes: 2 additions & 0 deletions
2
...log/unreleased/api-breaking/provider/1732-assigning-already-assigned-key-fix.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- Assigning a key that is already assigned by the same validator will now be a no-op instead of throwing an error. | ||
([\#1732](https://github.com/cosmos/interchain-security/pull/1732)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
- Adding the Partial Set Security (PSS) feature cf. [ADR 015](https://cosmos.github.io/interchain-security/adrs/adr-015-partial-set-security). | ||
PSS enables consumer chains to join ICS as _Top N_ or _Opt In_ chains and enables validators to opt to validate the consumer chains they want. | ||
([\#1809](https://github.com/cosmos/interchain-security/pull/1809)) |
2 changes: 2 additions & 0 deletions
2
...unreleased/features/provider/1587-enable-opt-in-chains-through-gov-proposals.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- Enable Opt In and Top N chains through gov proposals. | ||
([\#1587](https://github.com/cosmos/interchain-security/pull/1587)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- Adding the Partial Set Security feature cf. [ADR 015](https://cosmos.github.io/interchain-security/adrs/adr-015-partial-set-security). | ||
([\#1809](https://github.com/cosmos/interchain-security/pull/1809)) |
2 changes: 2 additions & 0 deletions
2
...ased/state-breaking/provider/1587-enable-opt-in-chains-through-gov-proposals.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- Enable Opt In and Top N chains through gov proposals. | ||
([\#1587](https://github.com/cosmos/interchain-security/pull/1587)) |
2 changes: 2 additions & 0 deletions
2
...g/unreleased/state-breaking/provider/1732-assigning-already-assigned-key-fix.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- Assigning a key that is already assigned by the same validator will now be a no-op instead of throwing an error. | ||
([\#1732](https://github.com/cosmos/interchain-security/pull/1732)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
module github.com/cosmos/interchain-security/v4 | ||
module github.com/cosmos/interchain-security/v5 | ||
|
||
go 1.21.1 | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be properly tested on Gaia as the transfer stack is much larger. @sainoe we should have upgrading instructions on how to integrate this and if there are any constraints on the order in the stack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I will create an issue to make sure we test the transfer stack in Gaia.