Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: revert compat breaks; cleanup #2235

Merged
merged 2 commits into from
Sep 6, 2024
Merged

fix!: revert compat breaks; cleanup #2235

merged 2 commits into from
Sep 6, 2024

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Sep 6, 2024

This PR reverts backward compatibility breaks introduced by #2171.

Changes to signer were reverted because they prevent parsing of existing messages stored in previous blocks.

Unused handlers were removed because they are dead code.

Unused proposals were marked as deprecated in protos. RPC methods that are no longer available were deleted because they cannot be used anyway.

@MSalopek MSalopek requested a review from a team as a code owner September 6, 2024 16:30
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Sep 6, 2024
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpoke mpoke enabled auto-merge September 6, 2024 16:52
@mpoke mpoke disabled auto-merge September 6, 2024 16:52
@mpoke mpoke merged commit 5b6252c into main Sep 6, 2024
13 of 16 checks passed
@mpoke mpoke deleted the masa/permissionless-review branch September 6, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants