feat!: enable standalone consumers to reuse existing clients for ICS #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/consumer
mpoke
commented
Nov 13, 2024
mpoke
changed the title
MSalopek
reviewed
Nov 13, 2024
MSalopek
reviewed
Nov 13, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mpoke
commented
Jan 2, 2025
mpoke
commented
Jan 2, 2025
MSalopek
reviewed
Jan 7, 2025
| * `chain_id` **MUST** be equal to the standalone chain id. | ||
| * The consumer initialization parameters (i.e., `initialization_parameters`) must be adapted for the changeover procedure: | ||
|
|
||
| * `initial_height` is not used as the provider uses an existing client of the standalone chain.. |
There was a problem hiding this comment.
What is the specific configuration that needs to be used? Can it be nil?
There was a problem hiding this comment.
I guess. In this case, this field is never used.
| - [ ] provide a repo with onboarding instructions for validators (it should already be listed in the proposal) | ||
| - [ ] genesis.json after `spawn_time` obtained from `provider` (MUST contain the initial validator set) | ||
| - [ ] maintenance & emergency contact info (relevant discord, telegram, slack or other communication channels) | ||
| Second, the `connection_id` field of `ConsumerGenesisState` must be removed to enable older versions of the consumer module to unmarshal the consumer module genesis state obtained from the provider. This can be done using the `interchain-security-cd genesis transform` CLI command. |
There was a problem hiding this comment.
I don't get it. Should the connection_id be removed or set to ""? This paragraph and the one before it are confusing.
There was a problem hiding this comment.
I added some clarification.
Co-authored-by: MSalopek <matija.salopek994@gmail.com>
Co-authored-by: MSalopek <matija.salopek994@gmail.com>
Co-authored-by: MSalopek <matija.salopek994@gmail.com>
Co-authored-by: MSalopek <matija.salopek994@gmail.com>
Co-authored-by: MSalopek <matija.salopek994@gmail.com>
…rity into marius/894-preccv
MSalopek
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #894
Remove code from
app/consumer-democracy/app.goAdd genesis transformation for compatibility with older consumer versions
Update docs -- changeover guidelines
Add e2e tests for standalone to consumer changeover
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if the change is state-machine breakingCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!the type prefix if the change is state-machine breaking